Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[f_legislationtracking] Design & Web App: Legislation Page #56

Closed
BrianL3 opened this issue Jun 3, 2021 · 6 comments · Fixed by #222
Closed

[f_legislationtracking] Design & Web App: Legislation Page #56

BrianL3 opened this issue Jun 3, 2021 · 6 comments · Fixed by #222
Labels
enhancement New feature or request
Projects

Comments

@BrianL3
Copy link
Collaborator

BrianL3 commented Jun 3, 2021

Use Case

There have been request(s) for a way of looking at a bill and seeing its legislative history, e.g. various amendments, votes, etc. This would be really cool, and our data model could support it (although it is not currently being scraped).

Solutions:

Some sort of tree visualization.
For inspiration, check this out: Washington State Bills from Legex Probably a bit more than we need but interesting, especially if we have a very detailed history of the bills that includes the various meetings where they have been discussed, public comment periods, etc.

A potential library for creating such visualizations: https://airbnb.io/visx/dendrograms

Please post other visions of what this might look like in the comments.

@evamaxfield evamaxfield added the enhancement New feature or request label Jun 3, 2021
@evamaxfield evamaxfield added the low priority Something to get to if we have time label Jun 17, 2021
@evamaxfield
Copy link
Member

@BrianL3 added low priority because we dont have a legislation page design yet and this is where that would go. if we have the time I would REALLY love to get this in though but prioritize last

@sarahjliu sarahjliu added this to To do in v3.0 Jul 10, 2021
@sarahjliu sarahjliu moved this from To do to Backlog in v3.0 Jul 10, 2021
@evamaxfield evamaxfield changed the title Visualizations of Legislative History Design & Web App: Legislation Page Sep 16, 2021
@evamaxfield evamaxfield added this to To do in v3.1 Sep 16, 2021
@evamaxfield evamaxfield removed this from Backlog in v3.0 Sep 16, 2021
@evamaxfield evamaxfield removed the low priority Something to get to if we have time label Jan 14, 2022
@tohuynh
Copy link
Collaborator

tohuynh commented Jan 14, 2022

Data requirements for the page:

  • Get the matter/legislation given the matter id. matter.name is the title of the page, while matter.title is the long description of the matter.
  • Get the keywords for the matter using the matter id
  • Get the sponsors by querying MatterSponsor given the matter id
  • Get the timeline of the matter by querying for MatterStatus give the the matter id. They should be sorted by matterstatus.update_datetime in desc.
  • The latest MatterStatus will provide information about the matter's status and last updated datetime
  • Use the latest MatterStatus to find the last event information. Use latest_matterstatus.event_minutes_item.event_ref
  • To get the votes for a timeline item, use the matterstatus.event_minutes_item_ref to query for Votes. Or query for Votes using the matter id, and then assemble the votes for each MatterStatus by using matterstatus.event_minutes_item_ref as a pivot.
  • To get the attachments of a timeline item, use the matterstatus.event_minutes_item_ref to query for EventMinutesItemFiles
  • To get the event information of a timeline item, use the matterstatus.event_minutes_item.event_ref to get the Event info
  • Missing data: timeline item description (e.g. "city clerk sent for review", "council president office sent for review" etc). This information is not in MatterStatus nor EventMinutesItem.

@JacksonMaxfield Am I missing anything?

@tohuynh
Copy link
Collaborator

tohuynh commented Jan 14, 2022

Page's "time to interactivity" consideration: the page should render after the "necessary" information has been fetched.
What would be the necessary information, everything except the timeline component?

@evamaxfield
Copy link
Member

First, this is an amazing write up. Thank you for doing this.

Missing data: timeline item description (e.g. "city clerk sent for review", "council president office sent for review" etc). This information is not in MatterStatus nor EventMinutesItem

Totally correct. For now our matter timelines will only reference events for the most part. But this is what I was talking about here: http://councildataproject.org/self/#/events/8ce513a84175?s=0&t=1613

If we get a metadata ingestion pipeline written then we may have more of this info which would be huge. (cc @dphoria)

Page's "time to interactivity" consideration: the page should render after the "necessary" information has been fetched.

What would be the necessary information, everything except the timeline component?

Yep. The timeline / history component should be accordian up / hidden on page load and the actual extra data should be loaded in the background.

@tohuynh tohuynh changed the title Design & Web App: Legislation Page [f_legislationtracking] Design & Web App: Legislation Page Jan 26, 2022
@evamaxfield
Copy link
Member

From meeting: let's try to deploy this feature sooner rather than later!

Let's deploy the all legislation page and the single legislation page without search and keywords.

We can add search and keywords later whenever the matter index pipeline is finished.

@tohuynh tohuynh linked a pull request May 13, 2022 that will close this issue
v3.1 automation moved this from To do to Done Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v3.1
Done
Development

Successfully merging a pull request may close this issue.

3 participants