feature/add-indexes-for-role-models

[evamaxfield]

Description of Changes

Include a description of the proposed changes.

Was working with Brian to make sure certain parts of the database are queryable for frontend stuff. These aren't needed but are nice to have.

[codecov]

Codecov Report

Merging #118 (a2cefd7) into main (009bdc5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files          50       50           
  Lines        2379     2379           
=======================================
  Hits         2276     2276           
  Misses        103      103           

Impacted Files	Coverage Δ
cdp_backend/database/models.py	100.00% <100.00%> (ø)
cdp_backend/database/types.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 009bdc5...a2cefd7. Read the comment docs.

[isaacna]

Looks good to me!

Also, I was thinking if it'd be worth creating some helper method that given some IndexField's, spits out a set of IndexedFieldSet with all or multiple permutations of order to reduce code repetition?

[isaacna]

Also, I was thinking if it'd be worth creating some helper method that given some IndexField's, spits out a set of IndexedFieldSet with all or multiple permutations of order to reduce code repetition?

Actually nvm I don't like this idea. I think having the index sets explicitly defined is probably better for a model class, and I'm assuming the exact combinations of order might be specific to the front end so creating them programmatically probably isn't worth the hassle

[evamaxfield]

Actually nvm I don't like this idea. I think having the index sets explicitly defined is probably better for a model class, and I'm assuming the exact combinations of order might be specific to the front end so creating them programmatically probably isn't worth the hassle

Yea. So uhhh, @BrianL3 and I just found more issues in the frontend libraries data models (models were missing entirely) and so I think the general solution still lies in #167

Like just have a giant JSON file that has all of these definitions and then in Python dynamically create them and same in TypeScript.