Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use QuerierWrapper not Querier in cw20 helpers #839

Merged
merged 5 commits into from Nov 1, 2022
Merged

Use QuerierWrapper not Querier in cw20 helpers #839

merged 5 commits into from Nov 1, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Oct 25, 2022

Closes #390 (again)

Reapplies changes from #394, which somehow got lost.

ethanfrey
ethanfrey reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, should we check all other contracts for the same issue?

@uint
Copy link
Contributor Author

uint commented Oct 25, 2022

looks good, should we check all other contracts for the same issue?

Sure. Only found one more.

@uint uint requested a review from ethanfrey October 25, 2022 16:31
@ethanfrey
Copy link
Member

Thanks for fixing the others. cw20 was the first one I think, as most requested. Funny it wasn't merged properly

@uint uint mentioned this pull request Nov 1, 2022
Closed
@uint uint merged commit 3610110 into main Nov 1, 2022
@uint uint deleted the querier-wrapper-in-helpers branch November 1, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 Awaiting requested review from webmaster128

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept &QuerierWrapper not &Querier in helpers
2 participants
@uint @ethanfrey