Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept &QuerierWrapper not &Querier in helpers #390

Closed
ethanfrey opened this issue Aug 22, 2021 · 4 comments · Fixed by #394 or #839
Closed

Accept &QuerierWrapper not &Querier in helpers #390

ethanfrey opened this issue Aug 22, 2021 · 4 comments · Fixed by #394 or #839
Assignees
Milestone

Comments

@ethanfrey
Copy link
Member

This has come up a few times and it seems to not be so usable currently. Most code has Deps or DepsMut, which contains &QuerierWrapper. However, the helpers want a Querier only to later cast it to a QuerierWrapper.

That plus the generic Q: Querier condition makes it very hard to use. Let's make these easier to use. (All of them, not just the cw721 in the example)

@ivanfong01
Copy link

I dun think this is closed? As the commit was rejected. Cw20 helper iss still using &Querier

@ethanfrey ethanfrey reopened this Oct 14, 2022
@ethanfrey
Copy link
Member Author

Yes, this is still an error. What happened to the above patch?
Let's get this fixed finally

@ethanfrey ethanfrey modified the milestones: v0.9.0, 0.16.0 Oct 14, 2022
@uint uint modified the milestones: 0.16.0, 0.17.0 Oct 17, 2022
@uint uint self-assigned this Oct 25, 2022
@uint
Copy link
Contributor

uint commented Oct 25, 2022

That patch isn't in git history on main. It feels like history was rewritten at some point? Odd. Regardless, I'll bring it back.

@uint
Copy link
Contributor

uint commented Nov 1, 2022

Done in #839

@uint uint closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants