Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go version to 1.18 #354

Merged
merged 3 commits into from Apr 6, 2022
Merged

upgrade go version to 1.18 #354

merged 3 commits into from Apr 6, 2022

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Apr 5, 2022

Description

upgrade go version from 1.17 to 1.18

Fixes #353

Note:
golanci-lint doesn't support go1.18 yet, check golangci/golangci-lint#2649
check golangci/golangci-lint#2438 to see which inters will be inactive.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner April 5, 2022 16:06
@maha-hajja maha-hajja marked this pull request as draft April 5, 2022 16:07
@maha-hajja maha-hajja marked this pull request as ready for review April 6, 2022 01:48
@maha-hajja maha-hajja merged commit 0d4222f into main Apr 6, 2022
@maha-hajja maha-hajja deleted the maha/go1.18 branch April 6, 2022 11:20
@lovromazgon
Copy link
Member

lovromazgon commented Apr 6, 2022

Looks like a bunch of linters don't work with Go 1.18 yet :/
We should keep an eye on this issue and update golangci-lint once it's resolved golangci/golangci-lint#2649

WARN [linters context] bodyclose is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] gosimple is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] noctx is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] rowserrcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] sqlclosecheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] staticcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] stylecheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] wastedassign is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] unused is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.

EDIT: Of course I didn't read the PR message, looks like @maha-hajja already pointed it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Go version to 1.18
3 participants