upgrade go version to 1.18 (#354)

* upgrade go version to 1.18

* fix linter

.github/workflows/build.yml

@@ -14,7 +14,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.17
+          go-version: 1.18
 
       - name: Test
         run: make test-integration GOTEST_FLAGS="-v -count=1"

.github/workflows/lint.yml

@@ -12,12 +12,12 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v2
         with:
-          go-version: 1.17
+          go-version: 1.18
 
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.44.2
+          version: v1.45.2
 
   buf-lint:
     runs-on: ubuntu-latest

.github/workflows/release.yml

@@ -22,7 +22,7 @@ jobs:
         name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.17
+          go-version: 1.18
       -
         name: Run GoReleaser
         uses: goreleaser/goreleaser-action@v2

Dockerfile

@@ -1,5 +1,5 @@
 # Start with a golang base
-FROM golang:1.17 AS base
+FROM golang:1.18 AS base
 
 # Install core tools
 RUN apt-get update &&\

README.md

@@ -54,7 +54,7 @@ and exploring the HTTP API through Swagger UI.
 ### Build from source
 
 Requirements:
-* [Go](https://golang.org/) (1.17 or later)
+* [Go](https://golang.org/) (1.18 or later)
 * [Node.js](https://nodejs.org/) (16.x)
 * [Yarn](https://yarnpkg.com/) (latest 1.x)
 * [Ember CLI](https://ember-cli.com/)

go.mod

@@ -1,6 +1,6 @@
 module github.com/conduitio/conduit
 
-go 1.17
+go 1.18
 
 require (
 	github.com/NYTimes/gziphandler v1.1.1

pkg/foundation/metrics/prometheus/prometheus_example_test.go

@@ -28,7 +28,7 @@ import (
 var (
 	testCounter = metrics.NewCounter("prom_example_counter", "example")
 	testTimer   = metrics.NewTimer("prom_example_timer", "example")
-	// nolint:unused,deadcode,varcheck // the whole point of this is to show that even unused gauges show up in prometheus
+	// nolint:deadcode,varcheck // the whole point of this is to show that even unused gauges show up in prometheus
 	testGauge = metrics.NewGauge("prom_example_gauge", "example")
 )
 

pkg/pipeline/lifecycle.go

@@ -358,7 +358,7 @@ func (s *Service) runPipeline(ctx context.Context, pl *Instance) error {
 			// If any of the nodes stops, the nodesTomb will be put into a dying state
 			// and ctx will be cancelled.
 			// This way, the other nodes will be notified that they need to stop too.
-			ctx := nodesTomb.Context(nil) //nolint:staticcheck // required by tomb
+			ctx := nodesTomb.Context(nil)
 			s.logger.Trace(ctx).Str(log.NodeIDField, node.ID()).Msg("running node")
 			defer func() {
 				e := s.logger.Trace(ctx)
@@ -405,7 +405,7 @@ func (s *Service) runPipeline(ctx context.Context, pl *Instance) error {
 	// before declaring the pipeline as stopped.
 	pl.t = &tomb.Tomb{}
 	pl.t.Go(func() error {
-		ctx := pl.t.Context(nil) //nolint:staticcheck // required by tomb
+		ctx := pl.t.Context(nil)
 		err := nodesTomb.Wait()
 
 		measure.PipelinesGauge.WithValues(strings.ToLower(pl.Status.String())).Dec()

pkg/plugin/acceptance_testing.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-//nolint:revive,dogsled,stylecheck // this is a test file
+//nolint:revive,dogsled // this is a test file
 package plugin
 
 import (