Merge pull request #141 from Comandeer/t/137

Add ability to pass plugins to Babel

package.json

@@ -69,6 +69,7 @@
     "rollup": ">=0.58.0"
   },
   "devDependencies": {
+    "@babel/plugin-syntax-dynamic-import": "^7.0.0",
     "@babel/preset-env": "^7.0.0",
     "@babel/register": "^7.0.0",
     "@comandeer/eslint-config": "^0.1.0",

src/index.js

@@ -16,7 +16,8 @@ function minify( options = {} ) {
 			const babelConf = {
 				presets: [ [ minifyPreset, minifyOptions ] ],
 				sourceMaps: typeof options.sourceMap !== 'undefined' ? Boolean( options.sourceMap ) : true,
-				comments: typeof options.comments !== 'undefined' ? Boolean( options.comments ) : true
+				comments: typeof options.comments !== 'undefined' ? Boolean( options.comments ) : true,
+				plugins: Array.isArray( options.plugins ) ? options.plugins : []
 			};
 			let banner;
 
@@ -26,11 +27,11 @@ function minify( options = {} ) {
 				const bannerContent = getCommentContent( banner );
 				let isAlreadyInserted = false;
 
-				babelConf.plugins = [
+				babelConf.plugins = babelConf.plugins.concat( [
 					[ bannerPlugin, {
 						banner
 					} ]
-				];
+				] );
 
 				if ( !babelConf.comments ) {
 					babelConf.shouldPrintComment = ( comment ) => {

src/utils.js

@@ -37,7 +37,8 @@ function filterMinifyOptions( options ) {
 		'banner',
 		'bannerNewLine',
 		'sourceMap',
-		'comments'
+		'comments',
+		'plugins'
 	];
 	const minifyOptions = {};
 

tests/banner.js

@@ -160,4 +160,24 @@ describe( 'banner and comments support', () => {
 			expect( bundle.code ).to.match( /^\/\* hublabubla \*\/[^\n]/ );
 		} );
 	} );
+
+	// #138
+	it ( 'works with other plugins', () => {
+		return createTransformTest( {
+			skipBabel: true,
+			fixture: 'dynamicImport',
+			rollupOptions: {
+				plugins: [
+					plugin( {
+						plugins: [
+							'@babel/plugin-syntax-dynamic-import'
+						],
+						banner: '/* hublabubla */'
+					} )
+				]
+			}
+		} ).then( ( { bundle } ) => {
+			expect( bundle.code ).to.match( /^\/\* hublabubla \*\// );
+		} );
+	} );
 } );

tests/fixtures/dynamicImport.js

@@ -0,0 +1,3 @@
+import( 'whatever' ).then( () => {
+
+} );

tests/helpers/createTransformTest.js

@@ -22,13 +22,14 @@ function getFixturePath( fixtureName ) {
 
 function createTransformTest( {
 	fixture = defaultFixture,
+	skipBabel = false,
 	babelOptions = defaultBabelOptions,
 	rollupOptions = defaultRollupOptions,
 	bundleOptions = defaultBundleOptions
 } = {} ) {
 	const path = getFixturePath( fixture );
 	const code = readFileSync( path, 'utf8' );
-	const babeledCode = transform( code, babelOptions );
+	const babeledCode = skipBabel !== true ? transform( code, babelOptions ) : null;
 
 	rollupOptions.input = path;
 

tests/index.js

@@ -1,5 +1,7 @@
 import chai from 'chai';
+import dynamicImportPlugin from '@babel/plugin-syntax-dynamic-import';
 import createTransformTest from './helpers/createTransformTest.js';
+import { defaultBabelOptions } from './helpers/createTransformTest.js';
 import plugin from '../src/index.js';
 
 const expect = chai.expect;
@@ -36,4 +38,46 @@ describe( 'plugin and its configuration', () => {
 			expect( bundle.code.trim() ).to.equal( transpiled.code );
 		} );
 	} );
+
+	// #137, #138
+	it( 'allows passing additional plugins by name', () => {
+		const pluginsOption = [ '@babel/plugin-syntax-dynamic-import' ];
+
+		return createTransformTest( {
+			fixture: 'dynamicImport',
+			babelOptions: Object.assign( {}, defaultBabelOptions, {
+				plugins: pluginsOption
+			} ),
+			rollupOptions: {
+				plugins: [
+					plugin( {
+						plugins: pluginsOption
+					} )
+				]
+			}
+		} ).then( ( { bundle, transpiled } ) => {
+			expect( bundle.code.trim() ).to.equal( transpiled.code );
+		} );
+	} );
+
+	// #137, #138
+	it( 'allows passing additional plugins by instance', () => {
+		const pluginsOption = [ dynamicImportPlugin ];
+
+		return createTransformTest( {
+			fixture: 'dynamicImport',
+			babelOptions: Object.assign( {}, defaultBabelOptions, {
+				plugins: pluginsOption
+			} ),
+			rollupOptions: {
+				plugins: [
+					plugin( {
+						plugins: pluginsOption
+					} )
+				]
+			}
+		} ).then( ( { bundle, transpiled } ) => {
+			expect( bundle.code.trim() ).to.equal( transpiled.code );
+		} );
+	} );
 } );