feat(banner): ensure that banner plugin cooperates with others

Comandeer · Nov 22, 2018 · 67fbf72 · 67fbf72
1 parent 4d42839
commit 67fbf72
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -27,11 +27,11 @@ function minify( options = {} ) {
 				const bannerContent = getCommentContent( banner );
 				let isAlreadyInserted = false;
 
-				babelConf.plugins = [
+				babelConf.plugins = babelConf.plugins.concat( [
 					[ bannerPlugin, {
 						banner
 					} ]
-				];
+				] );
 
 				if ( !babelConf.comments ) {
 					babelConf.shouldPrintComment = ( comment ) => {

diff --git a/tests/banner.js b/tests/banner.js
@@ -160,4 +160,24 @@ describe( 'banner and comments support', () => {
 			expect( bundle.code ).to.match( /^\/\* hublabubla \*\/[^\n]/ );
 		} );
 	} );
+
+	// #138
+	it ( 'works with other plugins', () => {
+		return createTransformTest( {
+			skipBabel: true,
+			fixture: 'dynamicImport',
+			rollupOptions: {
+				plugins: [
+					plugin( {
+						plugins: [
+							'@babel/plugin-syntax-dynamic-import'
+						],
+						banner: '/* hublabubla */'
+					} )
+				]
+			}
+		} ).then( ( { bundle } ) => {
+			expect( bundle.code ).to.match( /^\/\* hublabubla \*\// );
+		} );
+	} );
 } );
diff --git a/tests/helpers/createTransformTest.js b/tests/helpers/createTransformTest.js
@@ -22,13 +22,14 @@ function getFixturePath( fixtureName ) {
 
 function createTransformTest( {
 	fixture = defaultFixture,
+	skipBabel = false,
 	babelOptions = defaultBabelOptions,
 	rollupOptions = defaultRollupOptions,
 	bundleOptions = defaultBundleOptions
 } = {} ) {
 	const path = getFixturePath( fixture );
 	const code = readFileSync( path, 'utf8' );
-	const babeledCode = transform( code, babelOptions );
+	const babeledCode = skipBabel !== true ? transform( code, babelOptions ) : null;
 
 	rollupOptions.input = path;