Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdn_url? check shouldn't crash operations. Catch YAML.load failure #11033

Closed
wants to merge 1 commit into from
Closed

cdn_url? check shouldn't crash operations. Catch YAML.load failure #11033

wants to merge 1 commit into from

Commits on Nov 1, 2021

  1. cdn_url? check shouldn't crash operations. Catch YAML.load failure 

    Some services (i.e. gitlab) on https://url/repo.git/CocoaPods-version.yml will redirect to login page with http status 200.
Such response body will not be a valid YAML and throw exception.
HTML in a test case was YAML compatible, now it's a real garbage.
    @KostyaSha
    KostyaSha committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    acac580 View commit details
    Browse the repository at this point in the history