cdn_url? check shouldn't crash operations. Catch YAML.load failure #11033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some services (i.e. gitlab) on https://url/repo.git/CocoaPods-version.yml will redirect to login page with http status 200. Such response body will not be a valid YAML and throw exception. HTML in a test case was YAML compatible, now it's a real garbage.
|
@dnkoutso is it possible to backport it as a fix to 1.11.X? |
|
@KostyaSha yes lets do it can you rebase off of |
|
A lot of conflicts, pulled from new branch #11221 |
|
Going to close, the other PR supersedes that and it will be merged to master once 1.11.3 ships as part of the release process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some services (i.e. gitlab) on
https://url/repo.git/CocoaPods-version.ymlrequest will redirect to a login page with http status 200.Such response body will not be a valid YAML and throw exception.
HTML in a test case was YAML compatible, now it's a real garbage.
fixes #11010