[FEATURE] Compatibility with PHP 7.3+ and Composer 2.0 #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
var_export
byserialize()
for the generatedBundleDescriber
class to avoid circular referencesVersion matrix
The support for various versions is possible because
ocramius/package-versions
is now replaced bycomposer/package-versions-deprecated
which does exactly the same besides the fact that it supports a wider range of platform versions.However, we should keep in mind that the packages' name describes the actual state of the package: it's deprecated (but still supported). I'd suggest to keep it for now and remove the dependency once Composer 2.x has became established. We can then focus on the class generation provided by Composer.
Serialization
Since
var_export
cannot handle circular references (which is the case for the currently used installed packages objects), an alternative needed to be found. It turned out that serialization might be a good choice for now as it store the whole object/array representation and is also able to handle circular references.As a result,
var_export
has now been replaced byserialize()
. ThePropertyTrait
andInstalledPackagesTrait
have been adapted to resolve all serialized occurrences on first access.GitHub actions
This project now supports GitHub actions next to Travis CI. It would be great if we can get rid of Travis CI if it turns out that GitHub actions fulfill all our requirements: