[BUGFIX] Fix handling of InstalledPackagesTrait
#2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #1. It includes:
$resolvedPackages
instead of serialized$installedPackages
InstalledPackagesTrait
Usage of correct property
With #1,
var_export()
was replaced byserialize()
. Therefore theBundleDescriber
class property$installedPackages
does no longer contain an array, but rather its serialized representation. This leads to the fact that in case one uses theInstalledPackagesTrait
to access this property, it needs to be resolved first (usingunserialize()
on first access – this was already handled with #1) and should then return the resolved values from$resolvedPackages
.With #1, this was only partially implemented and has now been streamlined. Since the
InstalledPackagesTraitTest
was currently not included in the test execution workflow, those problems have not been discovered.Fix of
InstalledPackagesTraitTest
The Unit test class for
InstalledPackagesTrait
was currently not registered at the expected directorytests/Unit
. This has now been streamlined and the tests have been adapted to the previous mentioned modifications inInstalledPackagesTrait
.