[d2l-meter] property for hiding text #4587
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcotter
commented
Apr 10, 2024
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
abcotter
commented
Apr 10, 2024
| @@ -57,26 +74,33 @@ class MeterCircle extends MeterMixin(RtlMixin(LitElement)) { | |||
|
|
|||
| const primary = this._primary(this.value, this.max) || ''; | |||
| const secondary = this._secondary(this.value, this.max, this.text); | |||
| const secondaryTextElement = (this.text && !this.textHidden) ? html`<div class="d2l-body-small d2l-meter-circle-text-secondary">${secondary}</div>` : nothing; | |||
There was a problem hiding this comment.
there are 3 uses where we need to add text-hidden before we merge this https://d2l.slack.com/archives/C0PHG3QB0/p1712758960144389?thread_ts=1712758381.367159&cid=C0PHG3QB0
dbatiste
reviewed
Apr 10, 2024
dlockhart
reviewed
Apr 10, 2024
dbatiste
reviewed
Apr 10, 2024
dlockhart
reviewed
Apr 10, 2024
dlockhart
reviewed
Apr 10, 2024
abcotter
commented
Apr 11, 2024
dlockhart
reviewed
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
textproperty like the radial meter, however it only assigned it to the aria text. We'd like the circle meter to be able to behave similarly to the radial meterImplementation Details
text-hiddenprop to meter-mixin