Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating vdiff goldens for PR 4587 #4588

Draft
wants to merge 1 commit into
base: abcotter/visibleTextMeterCircle
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 10, 2024

This pull request updates the vdiff goldens for the changes in pull request #4587.

Please review the resulting report closely before merging to ensure the visual differences are expected.

@github-actions github-actions bot requested a review from abcotter April 10, 2024 18:05
@github-actions github-actions bot force-pushed the ghworkflow/vdiff-pr-4587 branch 4 times, most recently from 4a57424 to 836877b Compare April 10, 2024 20:25
@dlockhart
Copy link
Member

Looks like some unintended height changes here. Also, for the fit-content -- I didn't mean to imply that it should be removed, just that the behaviour for browsers who didn't support it looked sufficient to me for it to stay! :)

@github-actions github-actions bot force-pushed the ghworkflow/vdiff-pr-4587 branch 2 times, most recently from df2c7bd to b73e491 Compare April 16, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant