Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: fix build #117

Closed
wants to merge 1 commit into from
Closed

Commits on Dec 29, 2021

  1. GH Actions: fix build

    Both Composer, as well as PHPUnit have released new versions to try and fix the issue with tests being run with process isolation in combination with installation via Composer 2.2, which were resulting in the following error:
    ```
    PHPUnit\Framework\Exception: PHP Fatal error:  strict_types declaration must be the very first statement in the script in /home/runner/work/BrainMonkey/BrainMonkey/vendor/phpunit/phpunit/phpunit on line 2
    ```
    
    While that fixes the builds for runs against the `highest` versions of dependencies, it still does not solve the problem when running the tests with the `lowest` dependencies (or against PHP 5.6).
    
    Those builds now hang indefinitely.
    
    This commit attempts to fix this by using Composer 2.1 for builds against `lowest` dependencies and against PHP 5.6.
    
    It also sets a 15 minute time-out for the test runs against the `lowest` dependencies to prevent builds being very slow in reporting.
    
    Refs:
    * composer/composer#10387
    * sebastianbergmann/phpunit#4846
    * https://github.com/composer/composer/releases/tag/2.2.2
    * https://github.com/sebastianbergmann/phpunit/blob/9.5/ChangeLog-9.5.md#9511---2021-12-25
    jrfnl committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    17fb765 View commit details
    Browse the repository at this point in the history