GH Actions: fix build #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both Composer, as well as PHPUnit have released new versions to try and fix the issue with tests being run with process isolation in combination with installation via Composer 2.2, which were resulting in the following error: ``` PHPUnit\Framework\Exception: PHP Fatal error: strict_types declaration must be the very first statement in the script in /home/runner/work/BrainMonkey/BrainMonkey/vendor/phpunit/phpunit/phpunit on line 2 ``` While that fixes the builds for runs against the `highest` versions of dependencies, it still does not solve the problem when running the tests with the `lowest` dependencies (or against PHP 5.6). Those builds now hang indefinitely. This commit attempts to fix this by using Composer 2.1 for builds against `lowest` dependencies and against PHP 5.6. It also sets a 15 minute time-out for the test runs against the `lowest` dependencies to prevent builds being very slow in reporting. Refs: * composer/composer#10387 * sebastianbergmann/phpunit#4846 * https://github.com/composer/composer/releases/tag/2.2.2 * https://github.com/sebastianbergmann/phpunit/blob/9.5/ChangeLog-9.5.md#9511---2021-12-25
|
Some interesting additional information about this issue in the follow-up conversation here: composer/composer#10387 (comment) |
|
@gmazzap Looks like there may be a more comprehensive fix coming, so let's hold off on merging this one for now. I'm going to test the more comprehensive fix now. |
|
With the latest release of Composer (2.2.3), this PR is no longer necessary. The build for Closing this PR and I will be rebasing the other open PR to get passing builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Composer, as well as PHPUnit have released new versions to try and fix the issue with tests being run with process isolation in combination with installation via Composer 2.2, which were resulting in the following error:
While that fixes the builds for runs against the
highestversions of dependencies, it still does not solve the problem when running the tests with thelowestdependencies (or against PHP 5.6).Those builds now hang indefinitely.
This commit attempts to fix this by using Composer 2.1 for builds against
lowestdependencies and against PHP 5.6.It also sets a 15 minute time-out for the test runs against the
lowestdependencies to prevent builds being very slow in reporting.Refs:
Note: I will rebase the other open PRs after this PR has been merged to get their builds passing.