Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#34): add gitlab linking #37

Merged
merged 4 commits into from Jul 23, 2022
Merged

Conversation

yoannfleurydev
Copy link
Member

@yoannfleurydev yoannfleurydev commented Jun 19, 2022

@vercel
Copy link

vercel bot commented Jun 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
start-repo ✅ Ready (Inspect) Visit Preview Jul 23, 2022 at 1:31AM (UTC)

@yoannfleurydev yoannfleurydev self-assigned this Jun 19, 2022
@yoannfleurydev yoannfleurydev added the enhancement New feature or request label Jun 19, 2022
@yoannfleurydev yoannfleurydev changed the title feat(#34): add gitlab linking (waiting for … feat(#34): add gitlab linking Jun 19, 2022
Comment on lines +24 to +25
const githubAccount = data?.find((account) => account.provider === 'github');
const gitlabAccount = data?.find((account) => account.provider === 'gitlab');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be set in the backend to avoid client side computation and enjoy tRPC typings.

@yoannfleurydev yoannfleurydev marked this pull request as ready for review July 23, 2022 01:58
@yoannfleurydev yoannfleurydev merged commit 7867ec2 into main Jul 23, 2022
@yoannfleurydev yoannfleurydev deleted the feat/34-gitlab-link-account branch July 23, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to link the GitLab account.
1 participant