Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some logic to the backend #38

Open
yoannfleurydev opened this issue Jul 23, 2022 · 2 comments
Open

Move some logic to the backend #38

yoannfleurydev opened this issue Jul 23, 2022 · 2 comments
Labels

Comments

@yoannfleurydev
Copy link
Member

This can probably be set in the backend to avoid client side computation and enjoy tRPC typings.

Originally posted by @yoannfleurydev in #37 (comment)

@yoannfleurydev yoannfleurydev added the good first issue Good for newcomers label Jul 23, 2022
@garimellasrisudha
Copy link

Hi ,
Can you elaborate what exactly we have to do?
Apricate the efforts
Thank you

@yoannfleurydev
Copy link
Member Author

Hi , Can you elaborate what exactly we have to do? Apricate the efforts Thank you

Hi,

Those lines

const githubAccount = data?.find((account) => account.provider === 'github');
const gitlabAccount = data?.find((account) => account.provider === 'gitlab');
are, at the moment computed on the frontend (client side). This is a note to remind me that this logic can be put in the backend, as this project is using tRPC, the data retrieval will be typed with github and gitlab keys.

#37 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants