[release/1.2] Update tokio, rayon, and crossbeam to latest compatible versions #6136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings minimum crossbeam-utils version up to 0.7.2.
onalante-msft
force-pushed
the
crossbeam-1.2
branch
from
fa04fc6
to
78ca90a
Compare
arsing
requested changes
Feb 18, 2022
arsing
previously approved these changes
Feb 18, 2022
|
Actually, since you're updating i-i-s too, do that first, and then include the git reference bump in this PR too. |
onalante-msft
force-pushed
the
crossbeam-1.2
branch
from
f518a9d
to
72798d7
Compare
arsing
previously approved these changes
Feb 23, 2022
arsing
approved these changes
Feb 24, 2022
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
onalante-msft
added a commit
to onalante-msft/iotedge
that referenced
this pull request
Feb 24, 2022
…mpatible versions (Azure#6136)" This reverts commit 6a807eb.
6 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
… versions (#6172) *Cf.* #6136. The changes were previously reverted (#6160) due to conflicts with the release schedule. ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [ ] Title of the pull request is clear and informative. - [ ] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes. - Description of the pull request includes - [ ] concise summary of tests added/modified - [x] local testing done.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crossbeam-utils recently patched an unsoundness bug in
AtomicCellarithmetic: crossbeam-rs/crossbeam#781. However, this patch was not backported to the older versions required by tokio 0.1 and rayon. This PR updates tokio and rayon to the latest available versions, allowing some dependencies to upgrade to a safe crossbeam version. However, tokio still remains on a vulnerable version, so manual verification with a patched build was still required to determine that are not affected by the bug.The notary module had to be modified to remove the
tokio-processdependency due to the latter's reliance on crossbeam-utils 0.6 (through crossbeam-queue). notary now usestokio_threadpool::blocking.Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines