Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.2] Update regex to 1.5.5 #6198

Merged
merged 2 commits into from Mar 11, 2022

Conversation

onalante-msft
Copy link
Contributor

Contains mitigations for CVE-2022-24713.

https://www.whitesourcesoftware.com/vulnerability-database/CVE-2022-24713

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

Contains mitigations for CVE-2022-24713.
@onalante-msft onalante-msft requested review from arsing, varunpuranik, lfitchett and nyanzebra and removed request for lfitchett March 11, 2022 17:53
@@ -560,6 +560,7 @@ dependencies = [
"serde_json",
"sysinfo",
"tokio",
"tokio-threadpool",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, due to the notary module spawning a blocking task. edgelet-docker previously used tokio-process, but we had to remove that during the crossbeam-utils upgrade. Relevant discussion: #6136 (comment).

@onalante-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@kodiakhq kodiakhq bot merged commit cb20b6b into Azure:release/1.2 Mar 11, 2022
@onalante-msft onalante-msft deleted the regex-1.2 branch March 11, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants