Remove public API usage of ComponentSlotStyle and redefine type internally #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesBurnside
requested review from
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
PorterNan,
mgamis-msft,
prabhjot-msft,
AmyL219,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
CallWithChat bundle size is not changed.
|
Chat bundle size is not changed.
|
Calling bundle size is not changed.
|
emlynmac
approved these changes
Apr 28, 2023
PorterNan
reviewed
Apr 28, 2023
|
|
||
| import { IRawStyle } from '@fluentui/react'; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Would that be better to put this one in northstar wrapper?
There was a problem hiding this comment.
I did consider that but I'm actually against that as we shouldn't ever have publicly exported a fluent northstar interface and should have defined our own interface/used regular fluents in this package.
There was a problem hiding this comment.
(It also makes the bundling more difficult if we have a public API coming out of the northstar wrapper the way we rollup the api)
PorterNan
approved these changes
Apr 28, 2023
JamesBurnside
deleted the
jaburnsi/remove-public-usage-of-componentslotstyle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Redefine
ComponentSlotStylewith interoperable type from fluentuiThis works because IRawStyle allows any
Record<string, any>but has defined types for common CSS property (of which ComponentSlotStyle also supports) -- so is just a better version ofRecord<string, any>for styles properties.Why
We are removing usage of fluent n-star (see #2988) to support react 18 (see #1900) and we need to not rely on this type.
How Tested
Checked for interopability: