Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fluent n* with js bundle #2988

Merged
merged 19 commits into from
May 3, 2023
Merged

Replace fluent n* with js bundle #2988

merged 19 commits into from
May 3, 2023

Conversation

JamesBurnside
Copy link
Member

@JamesBurnside JamesBurnside commented Apr 26, 2023 •
edited

What

Replace fluent n* with single js bundle

  • Add webpack config to do bundling
    • bundles for both ESM and CJS
  • Replace usage of n* with bundle
  • Hook up build system to pick up n* wrapper package output

Why

Short term plan to support react 18 by removing react18 peer dependency (see #1900)

How Tested

  • Bundler should show no significant regression in app size ⚠️ todo: confirm this is reporting correctly/bundler is bundling correctly
  • CI snapshots ✅
  • All composites in samples apps running dev mode ✅
  • All composites and MessageThread in storybook ✅
  • All composites in sample apps running production build ✅
  • Static html composites ✅
  • Locally NPM pack and test package (primarily message thread component in local test app) ✅

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited

Calling bundle size is decreased✅.

  • Current size: 9791685
  • Base size: 9797692
  • Diff size: -6007

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited

CallWithChat bundle size is decreased✅.

  • Current size: 10187180
  • Base size: 10191715
  • Diff size: -4535

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited

Chat bundle size is decreased✅.

  • Current size: 9836209
  • Base size: 9839747
  • Diff size: -3538

@github-actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-gyevivewfb.chromatic.com/

@github-actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-tseqecptxf.chromatic.com/

@github-actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-cjgbqfftyj.chromatic.com/

@github-actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-tajbzxhhdl.chromatic.com/

@github-actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-wjlnwknqkb.chromatic.com/

@JamesBurnside JamesBurnside changed the title [🚧DRAFT - TEST] Test replacing fluent n* with single js bundle Replace fluent n* with js bundle Apr 27, 2023
@github-actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-luxpgkonka.chromatic.com/

@github-actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-mijeliijcb.chromatic.com/

@JamesBurnside JamesBurnside mentioned this pull request Apr 28, 2023
Merged
@JamesBurnside JamesBurnside requested review from a team as code owners April 28, 2023 20:24
@github-actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-thrjxnvoap.chromatic.com/

@JamesBurnside JamesBurnside changed the base branch from main to feature/react-18-short-term-support May 1, 2023 21:35
@JamesBurnside
Merge remote-tracking branch 'origin/feature/react-18-short-term-supp…
41db695 
…ort' into jaburnsi/replace-n-star-usage-with-single-bundle
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-vipvkkmrrp.chromatic.com/

emlynmac
emlynmac approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@emlynmac emlynmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JamesBurnside JamesBurnside merged commit 15c2622 into feature/react-18-short-term-support May 3, 2023
27 checks passed
@JamesBurnside JamesBurnside deleted the jaburnsi/replace-n-star-usage-with-single-bundle branch May 3, 2023 17:43
@JamesBurnside JamesBurnside mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlynmac emlynmac emlynmac approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 was automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev was automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft was automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft was automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms was automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo was automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai was automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter was automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft was automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft was automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft was automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan was automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft was automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft was automatically assigned from Azure/acs-ui-web-calling-reviewer-2

Assignees

@emlynmac emlynmac

@edwardlee-msft edwardlee-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JamesBurnside @emlynmac @edwardlee-msft