Update to mocha 7 #8108
Update to mocha 7 #8108
Conversation
xirzec
added
Client
xirzec
requested review from
bterlson,
chradek,
daviwil,
jeremymeng,
jiacfan,
sophiajt,
KarishmaGhiya,
ljian3377,
mikeharder,
ramya-rao-a,
richardpark-msft,
sadasant,
schaabs,
southpolesteve,
vinjiang,
willmtemple and
XiaoningLiu
as code owners
|
I think this fixes #5697 as well |
| @@ -57,8 +57,10 @@ describe("FileClient", () => { | |||
| }); | |||
|
|
|||
| afterEach(async function() { | |||
| await shareClient.delete(); | |||
| recorder.stop(); | |||
| if (!this.currentTest?.isPending()) { | |||
There was a problem hiding this comment.
Why this?
afterEach would anyway be executed only after the current test ends, right?
There was a problem hiding this comment.
Well issuing a delete breaks the recording, since the test was skipped and we didn't record that operation. We could also blanketly re-record everything, but it feels weird to do cleanup on skipped tests
There was a problem hiding this comment.
Ah, got the problem...
Previously, afterEach was skipped if the test is skipped, but with mocha@7.0.0, afterEach gets executed even if the test is skipped.
This is fine here, we can fix these in a followup issue.. #8110
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - eventhubs-client - tests |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage-blob - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks to @HarshaNalluru in #7931 we now can upgrade Mocha to the latest version.
Fixes #7932