Update to mocha 7 (#8108)

* Update to mocha 7

Fix tests by skipping afterEach steps that are now running in 7 that weren't before.

common/tools/eslint-plugin-azure-sdk/package.json

@@ -72,7 +72,7 @@
     "@types/eslint": "^4.16.8",
     "@types/estree": "0.0.39",
     "@types/glob": "^7.1.1",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
     "@typescript-eslint/experimental-utils": "^2.0.0",
@@ -81,7 +81,7 @@
     "bluebird": "^3.5.5",
     "chai": "^4.2.0",
     "eslint": "^6.1.0",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "prettier": "^1.16.4",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",

sdk/appconfiguration/app-configuration/package.json

@@ -86,7 +86,7 @@
     "@rollup/plugin-node-resolve": "^7.0.0",
     "@rollup/plugin-replace": "^2.2.0",
     "@types/chai": "^4.1.6",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@types/sinon": "^7.0.13",
     "assert": "^1.4.1",
@@ -97,7 +97,7 @@
     "eslint-plugin-no-null": "^1.0.2",
     "eslint-plugin-no-only-tests": "^2.3.0",
     "eslint-plugin-promise": "^4.1.1",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "nock": "^11.7.0",
     "nyc": "^14.0.0",

sdk/appconfiguration/app-configuration/test/etags.spec.ts

@@ -24,8 +24,10 @@ describe("etags", () => {
     });
   });
 
-  afterEach(async () => {
-    await deleteKeyCompletely([key], client);
+  afterEach(async function() {
+    if (!this.currentTest?.isPending()) {
+      await deleteKeyCompletely([key], client);
+    }
   });
 
   // etag usage is 'opt-in' via the onlyIfChanged/onlyIfUnchanged options for certain calls

sdk/appconfiguration/app-configuration/test/index.readonlytests.spec.ts

@@ -20,7 +20,7 @@ describe("AppConfigurationClient (set|clear)ReadOnly", () => {
   });
 
   after(async function() {
-    if (!this.currentTest!.isPending) {
+    if (!this.currentTest?.isPending()) {
       await deleteKeyCompletely([testConfigSetting.key], client);
     }
   });

sdk/appconfiguration/app-configuration/test/internal/http.spec.ts

@@ -124,9 +124,11 @@ describe("http request related tests", () => {
       scope = nock(/.*/);
     });
 
-    afterEach(() => {
-      assert.ok(scope.isDone());
-      nock.cleanAll();
+    afterEach(function() {
+      if (!this.currentTest?.isPending()) {
+        assert.ok(scope.isDone());
+        nock.cleanAll();
+      }
     });
 
     it("custom client request ID", async () => {
@@ -178,9 +180,11 @@ describe("http request related tests", () => {
       scope = nock(/.*/);
     });
 
-    afterEach(() => {
-      assert.ok(scope.isDone());
-      nock.cleanAll();
+    afterEach(function() {
+      if (!this.currentTest?.isPending()) {
+        assert.ok(scope.isDone());
+        nock.cleanAll();
+      }
     });
 
     it("policy is setup properly to send sync tokens", async function() {

sdk/appconfiguration/app-configuration/test/throwOrNotThrow.spec.ts

@@ -31,8 +31,10 @@ describe("Various error cases", () => {
       nonExistentKey = "non-existent key " + addedSetting.key;
     });
 
-    afterEach(async () => {
-      await deleteKeyCompletely([addedSetting.key], client);
+    afterEach(async function() {
+      if (!this.currentTest?.isPending()) {
+        await deleteKeyCompletely([addedSetting.key], client);
+      }
     });
 
     it("get: Non-existent key throws 404", async () => {
@@ -90,8 +92,10 @@ describe("Various error cases", () => {
       nonExistentKey = "bogus key " + addedSetting.key;
     });
 
-    afterEach(async () => {
-      await deleteKeyCompletely([addedSetting.key], client);
+    afterEach(async function() {
+      if (!this.currentTest?.isPending()) {
+        await deleteKeyCompletely([addedSetting.key], client);
+      }
     });
 
     it("get: value is unchanged from etag (304) using ifNoneMatch, sets all properties to undefined", async () => {

sdk/core/abort-controller/package.json

@@ -72,7 +72,7 @@
     "@rollup/plugin-multi-entry": "^3.0.0",
     "@rollup/plugin-node-resolve": "^7.0.0",
     "@rollup/plugin-replace": "^2.2.0",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
     "@typescript-eslint/parser": "^2.0.0",
@@ -95,7 +95,7 @@
     "karma-mocha": "^1.3.0",
     "karma-mocha-reporter": "^2.2.5",
     "karma-remap-istanbul": "^0.6.0",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "nyc": "^14.0.0",
     "prettier": "^1.16.4",

sdk/core/core-amqp/package.json

@@ -87,7 +87,7 @@
     "@types/chai-as-promised": "^7.1.0",
     "@types/debug": "^4.1.4",
     "@types/jssha": "^2.0.0",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@types/sinon": "^7.0.13",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
@@ -105,7 +105,7 @@
     "karma": "^4.0.1",
     "karma-chrome-launcher": "^3.0.0",
     "karma-mocha": "^1.3.0",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "nyc": "^14.0.0",
     "prettier": "^1.16.4",

sdk/core/core-arm/package.json

@@ -105,7 +105,7 @@
   "devDependencies": {
     "@rollup/plugin-node-resolve": "^7.0.0",
     "@types/chai": "^4.1.6",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
     "@typescript-eslint/parser": "^2.0.0",
@@ -115,7 +115,7 @@
     "eslint-plugin-no-null": "^1.0.2",
     "eslint-plugin-no-only-tests": "^2.3.0",
     "eslint-plugin-promise": "^4.1.1",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "npm-run-all": "^4.1.5",
     "nyc": "^14.0.0",

sdk/core/core-auth/package.json

@@ -68,7 +68,7 @@
     "@rollup/plugin-multi-entry": "^3.0.0",
     "@rollup/plugin-node-resolve": "^7.0.0",
     "@rollup/plugin-replace": "^2.2.0",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
     "@typescript-eslint/parser": "^2.0.0",
@@ -80,7 +80,7 @@
     "eslint-plugin-no-only-tests": "^2.3.0",
     "eslint-plugin-promise": "^4.1.1",
     "inherits": "^2.0.3",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "prettier": "^1.16.4",
     "rimraf": "^3.0.0",

sdk/core/core-http/package.json

@@ -154,7 +154,7 @@
     "@types/express": "^4.16.0",
     "@types/glob": "^7.1.1",
     "@types/karma": "^3.0.0",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@types/sinon": "^7.0.13",
     "@types/tough-cookie": "^2.3.5",
@@ -181,7 +181,7 @@
     "karma-mocha": "^1.3.0",
     "karma-rollup-preprocessor": "^7.0.0",
     "karma-sourcemap-loader": "^0.3.7",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-chrome": "^2.0.0",
     "mocha-junit-reporter": "^1.18.0",
     "npm-run-all": "^4.1.5",

sdk/core/core-lro/package.json

@@ -109,7 +109,7 @@
     "@rollup/plugin-node-resolve": "^7.0.0",
     "@rollup/plugin-replace": "^2.2.0",
     "@types/chai": "^4.1.6",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
     "@typescript-eslint/parser": "^2.0.0",
@@ -131,7 +131,7 @@
     "karma-mocha": "^1.3.0",
     "karma-mocha-reporter": "^2.2.5",
     "karma-remap-istanbul": "^0.6.0",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "npm-run-all": "^4.1.5",
     "nyc": "^14.0.0",

sdk/core/core-tracing/package.json

@@ -70,7 +70,7 @@
     "@rollup/plugin-multi-entry": "^3.0.0",
     "@rollup/plugin-node-resolve": "^7.0.0",
     "@rollup/plugin-replace": "^2.2.0",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
     "@typescript-eslint/parser": "^2.0.0",
@@ -82,7 +82,7 @@
     "eslint-plugin-no-only-tests": "^2.3.0",
     "eslint-plugin-promise": "^4.1.1",
     "inherits": "^2.0.3",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "prettier": "^1.16.4",
     "rimraf": "^3.0.0",

sdk/core/logger/package.json

@@ -77,7 +77,7 @@
     "@rollup/plugin-node-resolve": "^7.0.0",
     "@rollup/plugin-replace": "^2.2.0",
     "@types/chai": "^4.1.6",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@types/sinon": "^7.0.13",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
@@ -103,7 +103,7 @@
     "karma-mocha": "^1.3.0",
     "karma-mocha-reporter": "^2.2.5",
     "karma-remap-istanbul": "^0.6.0",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "nyc": "^14.0.0",
     "prettier": "^1.16.4",

sdk/cosmosdb/cosmos/package.json

@@ -98,7 +98,7 @@
     "@rollup/plugin-json": "^4.0.0",
     "@rollup/plugin-multi-entry": "^3.0.0",
     "@types/fast-json-stable-stringify": "^2.0.0",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@types/node-fetch": "^2.5.0",
     "@types/priorityqueuejs": "^1.0.1",
@@ -120,7 +120,7 @@
     "eslint-plugin-promise": "^4.1.1",
     "esm": "^3.2.18",
     "execa": "^3.3.0",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "prettier": "^1.16.4",
     "proxy-agent": "^3.1.1",

sdk/eventhub/event-hubs/package.json

@@ -102,7 +102,7 @@
     "@types/chai-string": "^1.4.1",
     "@types/debug": "^4.1.4",
     "@types/long": "^4.0.0",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@types/sinon": "^7.0.13",
     "@types/uuid": "^3.4.3",
@@ -133,7 +133,7 @@
     "karma-mocha": "^1.3.0",
     "karma-mocha-reporter": "^2.2.5",
     "karma-remap-istanbul": "^0.6.0",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "nyc": "^14.0.0",
     "prettier": "^1.16.4",

sdk/eventhub/event-processor-host/package.json

@@ -88,7 +88,7 @@
     "@types/chai-as-promised": "^7.1.0",
     "@types/chai-string": "^1.4.1",
     "@types/debug": "^4.1.4",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@types/uuid": "^3.4.3",
     "@types/ws": "^6.0.1",
@@ -106,7 +106,7 @@
     "eslint-plugin-promise": "^4.1.1",
     "esm": "^3.2.18",
     "https-proxy-agent": "^3.0.1",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "nyc": "^14.0.0",
     "prettier": "^1.16.4",

sdk/eventhub/eventhubs-checkpointstore-blob/package.json

@@ -78,7 +78,7 @@
     "@types/chai-as-promised": "^7.1.0",
     "@types/chai-string": "^1.4.1",
     "@types/debug": "^4.1.4",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
     "@typescript-eslint/parser": "^2.0.0",
@@ -107,7 +107,7 @@
     "karma-mocha": "^1.3.0",
     "karma-mocha-reporter": "^2.2.5",
     "karma-remap-istanbul": "^0.6.0",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "nyc": "^14.0.0",
     "prettier": "^1.16.4",

sdk/identity/identity/package.json

@@ -97,7 +97,7 @@
     "@rollup/plugin-replace": "^2.2.0",
     "@types/express": "^4.16.0",
     "@types/jws": "^3.2.0",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@types/qs": "^6.5.3",
     "@types/uuid": "^3.4.3",
@@ -116,7 +116,7 @@
     "karma-mocha": "^1.3.0",
     "karma-mocha-reporter": "^2.2.5",
     "karma-remap-istanbul": "^0.6.0",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "open": "^7.0.0",
     "prettier": "^1.16.4",

sdk/keyvault/keyvault-certificates/package.json

@@ -106,7 +106,7 @@
     "@rollup/plugin-replace": "^2.2.0",
     "@types/chai": "^4.1.6",
     "@types/fs-extra": "^8.0.0",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@types/query-string": "6.2.0",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
@@ -135,7 +135,7 @@
     "karma-mocha": "^1.3.0",
     "karma-mocha-reporter": "^2.2.5",
     "karma-remap-istanbul": "^0.6.0",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "nyc": "^14.0.0",
     "prettier": "^1.16.4",

sdk/keyvault/keyvault-keys/package.json

@@ -103,7 +103,7 @@
     "@rollup/plugin-replace": "^2.2.0",
     "@types/chai": "^4.1.6",
     "@types/fs-extra": "^8.0.0",
-    "@types/mocha": "^5.2.5",
+    "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@types/query-string": "6.2.0",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
@@ -132,7 +132,7 @@
     "karma-mocha": "^1.3.0",
     "karma-mocha-reporter": "^2.2.5",
     "karma-remap-istanbul": "^0.6.0",
-    "mocha": "^6.2.2",
+    "mocha": "^7.1.1",
     "mocha-junit-reporter": "^1.18.0",
     "nyc": "^14.0.0",
     "prettier": "^1.16.4",

sdk/keyvault/keyvault-keys/test/crypto.test.ts

@@ -36,8 +36,10 @@ describe("CryptographyClient (all decrypts happen remotely)", () => {
   });
 
   afterEach(async function() {
-    await testClient.flushKey(keyName);
-    recorder.stop();
+    if (!this.currentTest?.isPending()) {
+      await testClient.flushKey(keyName);
+      recorder.stop();
+    }
   });
 
   // The tests follow