Direct: Adds 3.23.1 version #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
sourabh1007
reviewed
Oct 25, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosContainerTests.cs
Show resolved
Hide resolved
added 2 commits
October 25, 2021 07:51
…re/azure-cosmos-dotnet-v3 into users/jawilley/direct/3.23.0
| @@ -13,7 +13,6 @@ namespace Microsoft.Azure.Cosmos.SDK.EmulatorTests | |||
| using System.Threading.Tasks; | |||
| using Microsoft.Azure.Cosmos.Resource.CosmosExceptions; | |||
| using Microsoft.Azure.Cosmos.Tracing; | |||
| using Microsoft.Azure.Documents; | |||
There was a problem hiding this comment.
Is using removal and full scoping intentional?
There was a problem hiding this comment.
Direct package file ClientEncryptionPolicy which had a breaking change that removed a property. Cosmos has it's own version of ClientEncryptionPolicy. The tests were validating the direct version instead of the public Cosmos version. I fixed all the tests to use the correct Cosmos.ClientEncryptionPolicy.
|
Also will leveraging non-blocking cache be a separate PR? |
kirankumarkolli
previously approved these changes
Oct 25, 2021
That will be done in a separate PR. The v3 SDK forked all of the routing files. |
sourabh1007
previously approved these changes
Oct 25, 2021
j82w
dismissed stale reviews from sourabh1007 and kirankumarkolli
via
8600eee
ealsur
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber