Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics: Add RetryAfter value #2773

Closed
j82w opened this issue Oct 5, 2021 · 1 comment
Closed

Diagnostics: Add RetryAfter value #2773

j82w opened this issue Oct 5, 2021 · 1 comment
Assignees
Labels
Diagnostics Issues around diagnostics and troubleshooting feature-request New feature or request
Milestone

Comments

@j82w
Copy link
Contributor

j82w commented Oct 5, 2021

The current cosmos diagnostics does not log the RetryAfter time. This makes it difficult to determine if the SDK is honoring the RetryAfter value and/or if the RetryAfter value is high which is the cause of the SDK delay.

The header value:

internal virtual string RetryAfterLiteral

This should be added to the StoreResult like BELatency so the v2 SDK will also get the value in the diagnostics:
https://msdata.visualstudio.com/_git/CosmosDB?path=/Product/Microsoft.Azure.Documents/SharedFiles/StoreResult.cs&version=GBmaster&line=340&lineEnd=341&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents

@j82w j82w added feature-request New feature or request Diagnostics Issues around diagnostics and troubleshooting labels Oct 5, 2021
@kirankumarkolli kirankumarkolli added this to the Jan 2022 milestone Dec 17, 2021
@j82w
Copy link
Contributor Author

j82w commented Jan 3, 2022

#2818

@j82w j82w closed this as completed Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diagnostics Issues around diagnostics and troubleshooting feature-request New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants