Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stats values in comparison table #90466

Merged
merged 2 commits into from
May 14, 2024
Merged

Update stats values in comparison table #90466

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26c5f35
Update stats values in comparison table
CodeyGuyDylan May 8, 2024
1dffc32
Fix typo
CodeyGuyDylan May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 27 additions & 3 deletions client/jetpack-cloud/sections/comparison/table/useComparisonData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,14 +228,38 @@ export const useComparisonData = () => {
icon: StatsIcon,
info: {
FREE: {
content: translate( 'Basic Stats' ),
content: (
<>
{ translate( 'Basic stats' ) }
<br data-screen="desktop" />
{ /* Space between description and parenthasis on mobile */ }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo in the comments for all 3 columns

Suggested change
{ /* Space between description and parenthasis on mobile */ }
{ /* Space between description and parenthesis on mobile */ }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

<span data-screen="mobile"> </span>
{ translate( '(Personal sites only)' ) }
</>
),
},
SECURITY: {
content: translate( 'Basic Stats' ),
content: (
<>
{ translate( 'Basic stats' ) }
<br data-screen="desktop" />
{ /* Space between description and parenthasis on mobile */ }
<span data-screen="mobile"> </span>
{ translate( '(Personal sites only)' ) }
</>
),
},
COMPLETE: {
highlight: true,
content: translate( 'All Stats' ),
content: (
<>
{ translate( 'Advanced stats' ) }
<br data-screen="desktop" />
{ /* Space between description and parenthasis on mobile */ }
<span data-screen="mobile"> </span>
{ translate( '(100k page views)' ) }
</>
),
},
},
},
Expand Down