Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stats values in comparison table #90466

Merged
merged 2 commits into from May 14, 2024

Conversation

CodeyGuyDylan
Copy link
Contributor

Proposed Changes

  • Update stats items in comparison table to be more accurate

Testing Instructions

  1. Use the Calypso Green live link or checkout this branch on your local environment
  2. Go to /features/comparison
  3. Make sure the copy has been updated according to this:
    image
    image
  4. Make sure mobile looks good too
    image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented May 8, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~51 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
jetpack-cloud-features-comparison       +448 B  (+0.1%)      +51 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@IanRamosC IanRamosC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a minor non-blocking comment

<>
{ translate( 'Basic stats' ) }
<br data-screen="desktop" />
{ /* Space between description and parenthasis on mobile */ }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo in the comments for all 3 columns

Suggested change
{ /* Space between description and parenthasis on mobile */ }
{ /* Space between description and parenthesis on mobile */ }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@CodeyGuyDylan CodeyGuyDylan merged commit 736ba6e into trunk May 14, 2024
9 of 11 checks passed
@CodeyGuyDylan CodeyGuyDylan deleted the update/stats-items-in-comparison-table branch May 14, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants