New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mongoose default option to set returnOriginal
#9189
Merged
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1bca5d1
docs(model): fix typo
AbdelrahmanHafez 2398073
test: repro #9183
AbdelrahmanHafez ea3954e
Merge branch '5.10' into gh-9183
AbdelrahmanHafez d3bfee4
feat(base): add option to set defaultNewOnFindAndUpdate
AbdelrahmanHafez 92610fc
docs(base): add defaultNewOnFindAndUpdateOrReplace as a valid option
AbdelrahmanHafez 263f1c4
fix(query): set default option only if it's not null
AbdelrahmanHafez 7613aed
treat `new` undefined as not mentioned on findOneAndUpdate
AbdelrahmanHafez 86f0c84
test(model): add test case verifying defaultNewOnFindAndUpdateOrRepla…
AbdelrahmanHafez ab3b38c
rename `defaultNewOnFindAndUpdateOrReplace` to `returnOriginal`
AbdelrahmanHafez 90b3217
docs(model): add note to use global option `returnOriginal`
AbdelrahmanHafez 402de9c
refactor: set `returnOriginal` instead of `new` with global `returnOr…
vkarpov15 04f9a7a
docs(returnOriginal): clarify that `returnOriginal` doesn't set `new`…
vkarpov15 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend setting
options.returnOriginal = returnOriginal
for consistency's sake. We convertnew
toreturnOriginal
under the hood anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable, I'll take a look at those changes in the next weekend, we can move this to 5.10.1 if it will delay things.