add mongoose default option to set returnOriginal
#9189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also changes option name defaultNewOnFindAndUpdate -> defaultNewOnFindAndUpdateOrReplace
AbdelrahmanHafez
changed the title
defaultNewOnFindAndUpdatedefaultNewOnFindAndUpdateOrReplace
vkarpov15
reviewed
Jul 3, 2020
AbdelrahmanHafez
changed the title
defaultNewOnFindAndUpdateOrReplacereturnOriginal
vkarpov15
requested changes
Jul 8, 2020
lib/query.js
Outdated
|
|
||
| const returnOriginal = get(this, 'model.base.options.returnOriginal'); | ||
| if (options.new == null && returnOriginal != null) { | ||
| options.new = !returnOriginal; |
There was a problem hiding this comment.
I'd recommend setting options.returnOriginal = returnOriginal for consistency's sake. We convert new to returnOriginal under the hood anyway.
There was a problem hiding this comment.
Sounds reasonable, I'll take a look at those changes in the next weekend, we can move this to 5.10.1 if it will delay things.
…, and link to `findOneAndUpdate()` tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9183
Also made a typo fix in the docs for
findOneAndReplace