New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks: only use strings in block descriptions #29757
Conversation
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run
to get started. More details: p9dueE-5Nn-p2 |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Marking as For my sake, I think making the DX worse at the expense of UX is not the way to go. I'd almost say I'd rather us add a notice ("We're aware of the deprecation notice thrown, but we're waiting for a better way of doing this from Core.", for example). The UX benefits of the status quo include links to support and a richer description overall. I vote to hold on to the status quo as long as possible until the deprecation turns into actually breaking or we have an alternative solution to provide rich content there. |
This PR has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with trunk, and it is still valid. Feel free to close this PR if you think it's not valid anymore — if you do, please add a brief explanation. |
Closing for now, we can reopen once we have a decision. |
Proposed changes:
Discussion: #26792
Until we have a better way to have custom descriptions for blocks, let's keep only strings to avoid notices. This isn't ideal since we're using useful information like links to support documentation, but at least we're getting rid of notices.
Closes #29402
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
On a site that runs WordPress 6.2 RC, go to Posts > Add New and open the browser console. You should not see any notices like this one: