Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: update CLI to only input strings in descriptions #30079

Merged
merged 2 commits into from Apr 13, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Apr 13, 2023

See #26792

Proposed changes:

Let's not encourage the use of non-strings in block descriptions; only strings should be used from now on.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Not much to test here, but you could try to run jetpack docker wp jetpack scaffold block something and check the files being created.

@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Apr 13, 2023
@jeherve jeherve self-assigned this Apr 13, 2023
@jeherve jeherve enabled auto-merge (squash) April 13, 2023 06:21
@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/block-skeleton

to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Apr 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: May 2, 2023.
  • Scheduled code freeze: April 24, 2023.

@bindlegirl
Copy link
Contributor

@jeherve I see #29757 is blocked. Should this PR wait for a decision on the first one?

@bindlegirl bindlegirl added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 13, 2023
@jeherve
Copy link
Member Author

jeherve commented Apr 13, 2023

Should this PR wait for a decision on the first one?

I think we could proceed with this, it will ensure that at least, we will not have more blocks added in the next few weeks / months that we'll need to modify.

@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Apr 13, 2023
Copy link
Contributor

@bindlegirl bindlegirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. LGTM

@jeherve jeherve merged commit f7d22ad into trunk Apr 13, 2023
56 of 57 checks passed
@jeherve jeherve deleted the update/block-skeleton branch April 13, 2023 13:08
@bindlegirl bindlegirl added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 13, 2023
@zinigor zinigor added this to the Jetpack/12.1 milestone Apr 24, 2023
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants