Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipython 7.31.0 #13

Closed
wants to merge 3 commits into from
Closed

ipython 7.31.0 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
448267a
DOR update to 7.31.0
anaconda-pkg-build Jan 5, 2022
c803829
Add script_env, update dependencies, add pytest
skupr-anaconda Jan 6, 2022
3745065
Update dependencies
skupr-anaconda Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 11 additions & 5 deletions recipe/meta.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
{% set version = "7.29.0" %}
{% set version = "7.31.0" %}

{% set migrating = False %}
{% set migrating = True %} # [win and python_impl == 'pypy']
Expand All @@ -9,12 +9,17 @@ package:

source:
url: https://pypi.io/packages/source/i/ipython/ipython-{{ version }}.tar.gz
sha256: 4f69d7423a5a1972f6347ff233e38bbf4df6a150ef20fbb00c635442ac3060aa
sha256: 346c74db7312c41fa566d3be45d2e759a528dcc2994fe48aac1a03a70cd668a3

build:
number: 0
script: {{ PYTHON }} -m pip install . -vv --no-deps
skip: true # [py<37]
script_env:
# Use MIGRATING environment variable instead of duplicating conditions into run_test.py.
# Combine script_env stanzas to avoid clobber
- MIGRATING={{ migrating }}
- IPYTHON_TESTING_TIMEOUT_SCALE=5
entry_points:
- ipython = IPython:start_ipython
- ipython3 = IPython:start_ipython
Expand All @@ -32,7 +37,7 @@ requirements:
- backcall
- colorama # [win]
- decorator
- jedi >=0.16,<1.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the upstream project fix their compatibility issues with Jedi 1.0? If not, we should probably keep the upper bound pinned.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the issue was with 0.18 and not 1.0 ipython/ipython#12813.

The upstream setup.py file has jedi >=0.16 https://github.com/ipython/ipython/blame/7.31.0/setup.py#L198
I found only this backport PR ipython/ipython@5e979ec and the PR ipython/ipython#12207

On conda-forge this pinning was removed starting with v7.30.0 too conda-forge@b64cd15

- jedi >=0.16
# earlier versions depended on ipython
- matplotlib-inline >=0.1.2
- pexpect >4.3 # [unix]
Expand All @@ -48,15 +53,16 @@ test:
- pip
{% if not migrating %}
- curio # [unix]
- ipykernel
- matplotlib-base
- nbformat
- nose >=0.10.1
- numpy
- numpy >=1.17
- pytest
- pygments
- requests
- testpath
- trio
- ipykernel
{% endif %}

imports:
Expand Down
8 changes: 6 additions & 2 deletions recipe/run_test.py
View file
Open in desktop
Expand Up @@ -6,9 +6,10 @@
WIN = platform.system() == "Windows"
LINUX = platform.system() == "Linux"
PYPY = "__pypy__" in sys.builtin_module_names
PPC = "ppc" in platform.machine()

# TODO: remove when all test dependencies are available on pypy37 for Windows
MIGRATING = WIN and PYPY
# Environment variable should be set in the meta.yaml
MIGRATING = eval(os.environ.get("MIGRATING", "None"))

# this is generally failing, for whatever reason
NOSE_EXCLUDE = ["recursion"]
Expand All @@ -22,6 +23,9 @@
# https://github.com/ipython/ipython/issues/12164
NOSE_EXCLUDE += ["system_interrupt"]

if PPC:
NOSE_EXCLUDE += ["ipython_dir_8", "audio_data"]

IPTEST_ARGS = []

if PYPY:
Expand Down