Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipython 7.31.0 #13

Closed
wants to merge 3 commits into from
Closed

Conversation

anaconda-pkg-build
Copy link

@anaconda-pkg-build anaconda-pkg-build commented Jan 5, 2022

Update ipython to 7.31.0

Version change: bump version number from 7.29.0 to 7.31.0
Bug Tracker: new open issues https://github.com/ipython/ipython/issues
Upstream license: License file: https://github.com/ipython/ipython/blob/master/LICENSE
Upstream setup.py: https://github.com/ipython/ipython/blob/7.31.0/setup.py

The package ipython is mentioned inside the packages:
altair | altair3_2 | altiar | caffe | caffe-gpu | glue-core | hdijupyterutils | holoviews | ipykernel | ipyparallel | ipython_genutils | ipywidgets | jira | jupyter_client | jupyter_console | jupyterlab | line_profiler | matplotlib | matplotlib-inline | metakernel | mpld3 | numba | pims | pivottablejs | pivottablejs-airgap | pyreadline | rasterio | rise | runipy | sas_kernel | scikit-bio | scikit-rf | sparkmagic | spyder | spyder-kernels | traitlets | widgetsnbextension | yt |

Actions:

  1. Add script_env:
  script_env:
    # Use MIGRATING environment variable instead of duplicating conditions into run_test.py.
    # Combine script_env stanzas to avoid clobber
    - MIGRATING={{ migrating }}
    - IPYTHON_TESTING_TIMEOUT_SCALE=5
  1. Update run dependencies
  2. Add pytest to test/requires
  3. Update run_test.py

Result:

  • all-succeeded

@skupr-anaconda skupr-anaconda self-assigned this Jan 6, 2022
@varlackc varlackc self-requested a review January 6, 2022 17:04
@@ -32,7 +37,7 @@ requirements:
- backcall
- colorama # [win]
- decorator
- jedi >=0.16,<1.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the upstream project fix their compatibility issues with Jedi 1.0? If not, we should probably keep the upper bound pinned.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the issue was with 0.18 and not 1.0 ipython/ipython#12813.

The upstream setup.py file has jedi >=0.16 https://github.com/ipython/ipython/blame/7.31.0/setup.py#L198
I found only this backport PR ipython/ipython@5e979ec and the PR ipython/ipython#12207

On conda-forge this pinning was removed starting with v7.30.0 too conda-forge@b64cd15

Copy link

@tobijk tobijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkreider
Copy link

Should we skip this version b/c of this vulnerability and get the next version out instead? GHSA-pq7m-3gw7-gq5x

@skupr-anaconda
Copy link

Yeah, we can skip building v7.31.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants