This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
fix: ensure terminal has required read settings in non-canonical mode #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Thank you! This looks good to me, especially because this is the same approach that golang.org/x/term uses too https://github.com/golang/term/blob/03fcf44c2211dcd5eb77510b5f7c1fb02d6ded50/term_unix.go#L38-L39
|
The CI failure is likely intermittent and will probably be resolved by #404 |
|
OK ... I don't seem to have permission to re-run the CI test to check that, but the tests do pass for me locally |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When taking the terminal out of canonical mode, the
VMINandVTIMEvalues become important. The rest of the code in this repo (unsurprisingly) expects the terminal to still operate in blocking read mode. However in some situations, notably in somescreensessions (for unknown reasons),VMINandVTIMEmay be set to 0 initially, which produces a range of errors, most commonly "false" EOF reports, but also sometimes panics.The bug this fixes can be reproduced without messing about with
screensimply by runningstty min 0 time 0before running any app that uses this library. A trivial test app I made to debug this issue is available at https://github.com/mgabeler-lee-6rs/survey-screen-eof-demofixes #408
see also cli/cli#4739