Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

fix: ensure terminal has required read settings in non-canonical mode #409

Merged
merged 2 commits into from Mar 17, 2022
Merged

fix: ensure terminal has required read settings in non-canonical mode #409

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c60389e
fix: ensure terminal has required read settings in non-canonical mode
mgabeler-lee-6rs Feb 16, 2022
b8e3583
Merge remote-tracking branch 'origin' into fix-408
mislav Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions terminal/runereader_posix.go
View file
Open in desktop
Expand Up @@ -50,6 +50,11 @@ func (rr *RuneReader) SetTermMode() error {

newState := rr.state.term
newState.Lflag &^= syscall.ECHO | syscall.ECHONL | syscall.ICANON | syscall.ISIG
// Because we are clearing canonical mode, we need to ensure VMIN & VTIME are
// set to the values we expect. This combination puts things in standard
// "blocking read" mode (see termios(3)).
newState.Cc[syscall.VMIN] = 1
newState.Cc[syscall.VTIME] = 0

if _, _, err := syscall.Syscall6(syscall.SYS_IOCTL, uintptr(rr.stdio.In.Fd()), ioctlWriteTermios, uintptr(unsafe.Pointer(&newState)), 0, 0, 0); err != 0 {
return err
Expand Down