Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump survey package to fix #982 #1087

Merged
merged 1 commit into from Jul 21, 2022
Merged

Bump survey package to fix #982 #1087

merged 1 commit into from Jul 21, 2022

Conversation

dangra
Copy link
Member

@dangra dangra commented Jul 20, 2022

I was able to reproduce #982 following the instructions at AlecAivazis/survey#228. The fix (AlecAivazis/survey#367) was shipped in survey v2.3.2 along with other interesting bugfixes AlecAivazis/survey#409.

Fixes #982

$ bash --norc
$ git checkout master
$ make
...

$ echo $'\e[?1h\E='
$ bin/flyctl pg create
? App Name: foo
? Select organization:  [Use arrows to move, type to filter]
> Daniel Graña (personal)
  Aligned Naar (aligned-naar)
Error Unexpected Escape Sequence: ['\x1b' 'O']

now with the fix applied it doesn't crash:

$ git checkout bugfix-982
Switched to branch 'bugfix-982'
Your branch is up to date with 'origin/bugfix-982'.
$ make
Running Generate for Help
go generate ./...
generating cli help
Running Build
go build -o bin/flyctl -ldflags="-X 'github.com/superfly/flyctl/internal/buildinfo.buildDate=2022-07-20T17:32:15Z'" .
Running Docs Generation
bash scripts/generate_docs.sh
Running doc/main.go
Cleaning up output

$ echo $'\e[?1h\E='
$ bin/flyctl pg create
? App Name: dangra-foo2
? Select organization: Aligned Naar (aligned-naar)
? Select region: mia (Miami, Florida (US))
For pricing information visit: https://fly.io/docs/about/pricing/#postgresql-clusters
? Select configuration:  [Use arrows to move, type to filter]
  Development - Single node, 1x shared CPU, 256MB RAM, 1GB disk
  Production - Highly available, 1x shared CPU, 256MB RAM, 10GB disk
> Production - Highly available, 1x Dedicated CPU, 2GB RAM, 50GB disk
  Production - Highly available, 2x Dedicated CPU's, 4GB RAM, 100GB disk
  Specify custom configuration

@rugwirobaker rugwirobaker merged commit 84be521 into master Jul 21, 2022
@rugwirobaker rugwirobaker deleted the bugfix-982 branch July 21, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PG config selection: Error Unexpected Escape Sequence: ['\x1b' 'O']
3 participants