Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch vega d3 fix fixme #2575

Merged
merged 5 commits into from Mar 4, 2021
Merged

Patch vega d3 fix fixme #2575

merged 5 commits into from Mar 4, 2021

Conversation

erights
Copy link
Member

@erights erights commented Mar 4, 2021 •
edited

Found and patched where vega-util was overriding Object.constructor by assignment.
Fixing that uncovered same problem with d3-color. Same patch.

vega-util was also overriding two other frozen primordial properties by assignment, hasOwnProperties and toString. Patched both, although toString is a hopeless cause. But fixing hasOwnProperties means SES can stop enabling it, further reducing vscode debugger's object inspector noise.

Fixes #2556

Fixes the FIXME kludge added to bin/runner at
https://github.com/Agoric/agoric-sdk/pull/2552/files/84f9ccf388e6aeb71b5aabb2a552e5ec36d4fa9f#r585869497

See
vega/vega#3075
endojs/endo#576

@erights erights self-assigned this Mar 4, 2021
This was referenced Mar 4, 2021
Merged
Closed
Closed
FUDCo
FUDCo approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@FUDCo FUDCo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea this patch mechanism existed. I don't know whether to be pleased or horrified by it, but in any case I'm glad to see this particular set of problems fixed.

dckc
dckc approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand this. But you might do well to stand by for reviews from others who are more confident.

patches/external-editor+3.1.0.patch Show resolved Hide resolved
michaelfig
michaelfig requested changes Mar 4, 2021
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after the behaviour changes are fixed.

patches/node-fetch+2.6.1.patch Show resolved Hide resolved
patches/vega-util+1.16.0.patch Outdated Show resolved Hide resolved
@erights erights enabled auto-merge (squash) March 4, 2021 17:40
@erights erights disabled auto-merge March 4, 2021 18:02
@erights erights requested a review from michaelfig March 4, 2021 18:02
@erights erights merged commit d4fa4f1 into master Mar 4, 2021
@erights erights deleted the 2556-markm-fix-vega-fixme branch March 4, 2021 18:32
@kriskowal kriskowal mentioned this pull request Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc approved these changes

@michaelfig michaelfig michaelfig approved these changes

@FUDCo FUDCo FUDCo approved these changes

Assignees

@erights erights

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate vega failure under SES 0.12.3
4 participants
@erights @dckc @michaelfig @FUDCo