Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade ses to 0.12.3 to avoid console noise #2552

Merged
merged 4 commits into from
Mar 2, 2021
Merged

fix: upgrade ses to 0.12.3 to avoid console noise #2552

merged 4 commits into from
Mar 2, 2021

Conversation

dckc
Copy link
Member

@dckc dckc commented Mar 2, 2021

fixes #2324

@dckc dckc requested review from erights and michaelfig March 2, 2021 00:12
erights
erights approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dckc dckc enabled auto-merge (rebase) March 2, 2021 00:16
@dckc dckc disabled auto-merge March 2, 2021 00:19
@dckc
Copy link
Member Author

dckc commented Mar 2, 2021

lint:types is not happy. interesting!

> @agoric/swingset-vat
$ yarn lint:types&&yarn lint:eslint
$ tsc -p jsconfig.json
Error: ../notifier/src/notifier.js(90,30): error TS2345: Argument of type 'UpdateRecord<T> | undefined' is not assignable to parameter of type 'UpdateRecord<T> | PromiseLike<UpdateRecord<T>>'.

@dckc dckc mentioned this pull request Mar 2, 2021
Closed
@dckc dckc enabled auto-merge (squash) March 2, 2021 01:51
michaelfig
michaelfig approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dckc
Copy link
Member Author

dckc commented Mar 2, 2021

@FUDCo any clues on the swingset-runner test/test-demo.js:25 failure?

https://github.com/Agoric/agoric-sdk/pull/2552/checks?check_run_id=2009422750

@michaelfig michaelfig force-pushed the ses-fix-console-noise branch 2 times, most recently from cc5ba13 to 6cf75c6 Compare March 2, 2021 19:58
michaelfig
michaelfig reviewed Mar 2, 2021
View reviewed changes
packages/swingset-runner/bin/runner
Comment on lines +13 to +19
// FIXME: Without importing vega ahead of lockdown,
// node -r esm bin/runner --init --memdb run demo/encouragementBot
// exits with error code 1, just printing `{}`.
//
// Since this started with ses@0.12.3 we suspect vega is somehow
// hitting the override mistake with `constructor`.
import 'vega';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to investigate this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the comment is too specific. The problem will occur with any invocation of swingset-runner regardless of the command line options.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2575

@michaelfig michaelfig mentioned this pull request Mar 2, 2021
Closed
@dckc dckc merged commit f59f5f5 into master Mar 2, 2021
@dckc dckc deleted the ses-fix-console-noise branch March 2, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erights erights erights approved these changes

@michaelfig michaelfig michaelfig approved these changes

@FUDCo FUDCo FUDCo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get rid of <[Object: null prototype] {}> console noise
4 participants
@dckc @erights @michaelfig @FUDCo