Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: windows-bindings: force 1.69 due to cargo regression in 1.70 #172

Merged
merged 1 commit into from Aug 11, 2023

Conversation

commial
Copy link
Contributor

@commial commial commented Aug 11, 2023

Temporary fix for the CI: bindings tests no more compile with cargo 1.70.
It seems to be a regression in the way cargo handle paths in a workspace environment.

For now, force the toolchain version to 1.69 only in the Windows' binding tests.

@commial commial added the tests Relative to the testing capabilities label Aug 11, 2023
@commial
Copy link
Contributor Author

commial commented Aug 11, 2023

Tracked by #173

@commial commial merged commit 22b1162 into master Aug 11, 2023
22 of 23 checks passed
@commial commial deleted the fix-msbuild branch August 11, 2023 20:50
@github-actions
Copy link

Benchmark for f4b904c

Click to view benchmark
Test Base PR %
chunk_size_decompress_mutilfiles_random/Layers(0x0)/1024 750.5±79.33ns 749.0±76.13ns -0.20%
chunk_size_decompress_mutilfiles_random/Layers(0x0)/1048576 93.9±6.35µs 99.6±7.20µs +6.07%
chunk_size_decompress_mutilfiles_random/Layers(0x0)/16777216 1649.7±61.10µs 1485.3±9.94µs -9.97%
chunk_size_decompress_mutilfiles_random/Layers(0x0)/65536 6.8±0.58µs 6.9±0.69µs +1.47%
chunk_size_decompress_mutilfiles_random/Layers(COMPRESS)/1024 816.7±450.89µs 816.1±449.51µs -0.07%
chunk_size_decompress_mutilfiles_random/Layers(COMPRESS)/1048576 35.7±0.14ms 35.7±0.17ms 0.00%
chunk_size_decompress_mutilfiles_random/Layers(COMPRESS)/16777216 192.2±0.66ms 193.1±0.54ms +0.47%
chunk_size_decompress_mutilfiles_random/Layers(COMPRESS)/65536 7.8±4.43ms 7.8±4.45ms 0.00%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT | COMPRESS)/1024 1064.6±585.86µs 1061.6±583.92µs -0.28%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT | COMPRESS)/1048576 47.2±0.08ms 47.2±0.12ms 0.00%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT | COMPRESS)/16777216 382.7±0.77ms 382.8±0.76ms +0.03%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT | COMPRESS)/65536 9.9±4.67ms 9.9±4.69ms 0.00%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT)/1024 1430.5±507.05µs 1429.3±507.21µs -0.08%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT)/1048576 16.7±0.01ms 16.7±0.01ms 0.00%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT)/16777216 241.6±0.14ms 242.0±0.09ms +0.17%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT)/65536 2.7±0.12ms 2.7±0.12ms 0.00%
failsafe_multiple_layers_repair/Layers(0x0)/4194304 66.0±0.79ms 65.9±0.70ms -0.15%
failsafe_multiple_layers_repair/Layers(COMPRESS)/4194304 115.6±0.34ms 116.1±0.43ms +0.43%
failsafe_multiple_layers_repair/Layers(ENCRYPT | COMPRESS)/4194304 132.4±0.36ms 132.7±0.16ms +0.23%
failsafe_multiple_layers_repair/Layers(ENCRYPT)/4194304 87.9±0.63ms 88.2±0.44ms +0.34%
reader_multiple_layers_multiple_block_size/Layers(0x0)/1024 142.3±11.70ns 137.3±14.08ns -3.51%
reader_multiple_layers_multiple_block_size/Layers(0x0)/1048576 86.9±5.11µs 88.4±3.60µs +1.73%
reader_multiple_layers_multiple_block_size/Layers(0x0)/16777216 1464.1±58.44µs 1376.6±8.17µs -5.98%
reader_multiple_layers_multiple_block_size/Layers(0x0)/65536 5.2±0.47µs 5.5±0.53µs +5.77%
reader_multiple_layers_multiple_block_size/Layers(COMPRESS)/1024 2.4±2.46µs 2.4±2.47µs 0.00%
reader_multiple_layers_multiple_block_size/Layers(COMPRESS)/1048576 2.5±0.04ms 2.5±0.02ms 0.00%
reader_multiple_layers_multiple_block_size/Layers(COMPRESS)/16777216 144.5±0.76ms 143.9±0.70ms -0.42%
reader_multiple_layers_multiple_block_size/Layers(COMPRESS)/65536 153.3±159.38µs 154.2±160.38µs +0.59%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/1024 21.6±3.09µs 21.6±3.11µs 0.00%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/1048576 22.8±0.03ms 23.3±0.03ms +2.19%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/16777216 378.0±0.48ms 377.9±0.57ms -0.03%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/65536 1326.9±181.50µs 1330.0±181.52µs +0.23%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT)/1024 14.2±0.85µs 14.1±0.83µs -0.70%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT)/1048576 14.8±0.01ms 14.8±0.42ms 0.00%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT)/16777216 239.6±0.06ms 239.6±0.07ms 0.00%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT)/65536 900.8±52.92µs 901.4±52.68µs +0.07%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(0x0)/1024 623.6±34.26ns 635.3±36.72ns +1.88%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(0x0)/1048576 97.9±6.62µs 92.4±4.83µs -5.62%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(0x0)/16777216 1455.7±16.57µs 1381.6±8.72µs -5.09%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(0x0)/65536 7.0±0.77µs 6.2±0.30µs -11.43%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(COMPRESS)/1024 13.5±0.13µs 13.5±0.12µs 0.00%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(COMPRESS)/1048576 12.0±0.04ms 12.0±0.06ms 0.00%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(COMPRESS)/16777216 191.9±0.52ms 191.9±0.77ms 0.00%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(COMPRESS)/65536 749.5±5.67µs 756.7±15.39µs +0.96%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT | COMPRESS)/1024 26.0±0.25µs 26.0±0.34µs 0.00%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT | COMPRESS)/1048576 23.9±0.05ms 23.9±0.05ms 0.00%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT | COMPRESS)/16777216 382.8±0.40ms 383.1±0.46ms +0.08%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT | COMPRESS)/65536 1480.3±15.99µs 1476.2±13.76µs -0.28%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT)/1024 16.7±0.18µs 16.9±0.27µs +1.20%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT)/1048576 15.1±0.01ms 15.1±0.01ms 0.00%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT)/16777216 241.5±0.06ms 241.3±0.04ms -0.08%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT)/65536 945.6±0.60µs 947.2±0.88µs +0.17%
writer_multiple_layers_multiple_block_size/Layers(0x0)/1024 8.3±0.06µs 8.3±0.07µs 0.00%
writer_multiple_layers_multiple_block_size/Layers(0x0)/1048576 8.2±0.21ms 8.2±0.20ms 0.00%
writer_multiple_layers_multiple_block_size/Layers(0x0)/16777216 131.8±0.46ms 131.5±0.44ms -0.23%
writer_multiple_layers_multiple_block_size/Layers(0x0)/65536 512.0±13.05µs 511.9±13.95µs -0.02%
writer_multiple_layers_multiple_block_size/Layers(COMPRESS)/1024 13.5±0.13µs 13.6±0.27µs +0.74%
writer_multiple_layers_multiple_block_size/Layers(COMPRESS)/1048576 18.4±0.47ms 18.4±0.49ms 0.00%
writer_multiple_layers_multiple_block_size/Layers(COMPRESS)/16777216 520.1±1.06ms 526.8±2.98ms +1.29%
writer_multiple_layers_multiple_block_size/Layers(COMPRESS)/65536 841.7±10.50µs 848.4±35.68µs +0.80%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/1024 13.4±0.12µs 13.6±0.39µs +1.49%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/1048576 21.3±0.72ms 21.3±0.72ms 0.00%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/16777216 705.5±3.60ms 710.1±1.76ms +0.65%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/65536 846.1±13.42µs 832.6±12.18µs -1.60%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT)/1024 24.2±0.32µs 24.1±0.05µs -0.41%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT)/1048576 23.3±0.09ms 23.3±0.08ms 0.00%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT)/16777216 374.0±0.70ms 374.0±0.57ms 0.00%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT)/65536 1457.7±7.14µs 1459.0±8.61µs +0.09%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Relative to the testing capabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant