Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump to latest version of docker build to address provenance issue #6

Merged
merged 2 commits into from Feb 14, 2023
Merged

fix: bump to latest version of docker build to address provenance issue #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7763b75
fix: bump to latest version of docker build to address provenance issue
chanange Feb 14, 2023
5d2c07f
chore: bump to v4 docker build action and explicitly set provenance to
chanange Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/dagster.yml
View file
Open in desktop
Expand Up @@ -52,7 +52,7 @@ jobs:
with:
task: 'remove'
helm: helm3
repository: "https://dagster-io.github.io/helm"
repository: 'https://dagster-io.github.io/helm'
chart: 'dagster'
release: "${{ format('{0}-pr-{1}', inputs.image_name, github.event.number) }}"
namespace: 'dagster'
Expand All @@ -79,7 +79,7 @@ jobs:
ssh-add - <<< "${{ secrets.SSH_KEY }}"

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
uses: docker/setup-buildx-action@v2.4.1

- name: Set up Cloud SDK
uses: google-github-actions/setup-gcloud@v0.2.1
Expand All @@ -97,7 +97,7 @@ jobs:
run: echo ::set-output name=IMAGE_FULLNAME::eu.gcr.io/${{ inputs.gcp_project }}/${{ inputs.image_name }}:${GITHUB_REF#refs/tags/}

- name: Build docker image
uses: docker/build-push-action@v2
uses: docker/build-push-action@v4.0.0
env:
SSH_AUTH_SOCK: /tmp/ssh_agent.sock
with:
Expand All @@ -120,7 +120,7 @@ jobs:
for i in $(seq 1 10); do /tmp/grpc_health_probe -addr=localhost:8080 && s=0 && break || s=$? && sleep 2; done; (docker logs test_container && exit $s)

- name: Push docker image
uses: docker/build-push-action@v2
uses: docker/build-push-action@v4.0.0
env:
SSH_AUTH_SOCK: /tmp/ssh_agent.sock
with:
Expand All @@ -133,6 +133,7 @@ jobs:
${{ github.ref == format('refs/heads/{0}', inputs.branch) && format('eu.gcr.io/{0}/{1}:stage', inputs.gcp_project, inputs.image_name) || '' }}
${{ startsWith(github.ref, 'refs/tags/') && steps.get_tag.outputs.IMAGE_FULLNAME || '' }}
${{ startsWith(github.ref, 'refs/tags/') && format('eu.gcr.io/{0}/{1}:prod', inputs.gcp_project, inputs.image_name) || '' }}
provenance: false # Image attestations not supported in GCR: https://github.com/docker/buildx/issues/1533

- uses: google-github-actions/get-gke-credentials@v0.3.0
with:
Expand All @@ -150,7 +151,7 @@ jobs:
uses: AndreaGiardini/helm@master # Should be replaced with deliverybot/helm@v1 when https://github.com/deliverybot/helm/issues/66 is fixed
with:
helm: helm3
repository: "https://dagster-io.github.io/helm"
repository: 'https://dagster-io.github.io/helm'
chart: 'dagster'
release: "${{ format('{0}-pr-{1}', inputs.image_name, github.event.number) }}"
namespace: 'dagster'
Expand Down