fix: bump to latest version of docker build to address provenance issue #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's bump to v4, and then also set |
|
We can always move to artifact registry later, but this is an easier fix and puts us on latest, and I do love being on latest :) |
chanange
force-pushed
the
bump-docker-action
branch
from
40a1c52
to
5d2c07f
Compare
|
Tested on viaduct PR and confirmed attestations are not generated/build is working as expected: https://github.com/20treeAI/viaduct/actions/runs/4171990362/jobs/7223576502 |
jessebot
approved these changes
Feb 14, 2023
jessebot
added a commit
that referenced
this pull request
Mar 29, 2023
fix: bump to latest version of docker build to address provenance issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker/build-push-action#781
Addresses issue with GCR not supporting attestations. Ref: docker/buildx#1533
Looks like we'll need to move to artifact registry before going to
docker/build-push-action@v4or explicitly setprovenance: falsein v4.