Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle not supported content encoding #327

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Commits on Sep 6, 2019

  1. update HtmlWeb.cs so as not to parse content encoding when overriding…

    … encoding
    
    Although HtmlWeb class allows to ignore resp.ContentEncoding by OverrideEncoding property, it cannot help in the case where resp.ContentEncoding has encoding name which is not supported by Encoding class. This is because Encoding.GetEncoding method throws ArgumentException in that case.
    
    When OverrideEncoding is provided, the result from resp.ContentEncoding has not been used, so that simply skipping Encoding.GetEncoding method call can make it work.
    
    EncodingNotSupportedException is added in order to notify that such not supported content encoding is received in the response, with the information of the received content encoding name. This is more helpful than ArgumentException.
    y-code committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    19f19af View commit details
    Browse the repository at this point in the history
  2. update EncodingNotSupportedException to make Encoding property access…

    …ible in public
    
    modify access modifier of Encoding property of EncodingNotSupportedException from internal to public.
    y-code committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    beb34cd View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. make HtmlWeb class testable

    wrap HttpRequest and HttpResponse with interfaces, and make HtmlWeb class testable.
    y-code committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    73060a6 View commit details
    Browse the repository at this point in the history
  2. add a test project targeting multiple .NET versions

    add a test project targeting multiple .NET version.
    copy the existing tests in HtmlAgilityPack.Tests.Net45.
    y-code committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    494038d View commit details
    Browse the repository at this point in the history
  3. add test code generator

    add test code generator
    y-code committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    8d05430 View commit details
    Browse the repository at this point in the history
  4. add test code for HtmlWeb.Load method

    add test code for HtmlWeb.Load method
    y-code committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    10fcb6f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b1d74b0 View commit details
    Browse the repository at this point in the history
  6. modify test project target to core 2.1

    It turned out NUnit tests are not running with core 2.0. Therefore, changed test project target to core 2.1 so that we can run tests over .NET Core.
    y-code committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    e37d166 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. add documentation comments

    y-code committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    66f7075 View commit details
    Browse the repository at this point in the history
  2. add lacking using statements

    y-code committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    e183a20 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    df65211 View commit details
    Browse the repository at this point in the history
  4. add mshome.html file load to mock in HtmlWebTests.TestLoad

    add mshome.html file load to mock in HtmlWebTests.TestLoad.
    modify how to get assembly location in generated test code in HtmlWebTestGenerator.
    y-code committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    ea6c29f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7fbaf94 View commit details
    Browse the repository at this point in the history
  6. correct Preprocessor symbols used in HtmlWebResponseWrapper

    The code was never be active because of the wrong condition and wrong symbols in the processor directive.
    
    correct it so that the code is activated in net4.5 and newer.
    add a preprocessor symbol in two projects so as to build HtmlAgilityPack.Master solution also with Debug configuration.
    y-code committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    d9dad64 View commit details
    Browse the repository at this point in the history