Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing non ISO-8859-1 characters in PDF417 input with '?' #1514

Merged
merged 2 commits into from Apr 27, 2022
Merged

Replacing non ISO-8859-1 characters in PDF417 input with '?' #1514

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1220abd
Replacing non ISO-8859-1 characters in input with '?' when neither a …
AlexGeller1 Apr 19, 2022
4d2367e
Changed code to raise an exception for characters not encodeable in I…
AlexGeller1 Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/src/main/java/com/google/zxing/pdf417/encoder/PDF417HighLevelEncoder.java
View file
Open in desktop
Expand Up @@ -171,6 +171,15 @@ private PDF417HighLevelEncoder() {
static String encodeHighLevel(String msg, Compaction compaction, Charset encoding, boolean autoECI)
throws WriterException {

if (encoding == null && !autoECI) {
for (int i = 0; i < msg.length(); i++) {
if (msg.charAt(i) > 255) {
throw new WriterException("Non-encodable character detected: " + msg.charAt(i) + " (Unicode: " +
(int) msg.charAt(i) +
"). Consider specifying EncodeHintType.PDF417_AUTO_ECI and/or EncodeTypeHint.CHARACTER_SET.");
}
}
}
//the codewords 0..928 are encoded as Unicode characters
StringBuilder sb = new StringBuilder(msg.length());

Expand Down