Reduce PDF417 variance leniency (fixes #1624) (#1628)

zxing · May 23, 2023 · 72f5ee7 · 72f5ee7
1 parent 807fb0b
commit 72f5ee7
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/core/src/main/java/com/google/zxing/pdf417/detector/Detector.java b/core/src/main/java/com/google/zxing/pdf417/detector/Detector.java
@@ -40,7 +40,7 @@ public final class Detector {
   private static final int[] INDEXES_START_PATTERN = {0, 4, 1, 5};
   private static final int[] INDEXES_STOP_PATTERN = {6, 2, 7, 3};
   private static final float MAX_AVG_VARIANCE = 0.42f;
-  private static final float MAX_INDIVIDUAL_VARIANCE = 0.8f;
+  private static final float MAX_INDIVIDUAL_VARIANCE = 0.7f;
 
   // B S B S B S B S Bar/Space pattern
   // 11111111 0 1 0 1 0 1 000

diff --git a/core/src/test/java/com/google/zxing/pdf417/PDF417BlackBox1TestCase.java b/core/src/test/java/com/google/zxing/pdf417/PDF417BlackBox1TestCase.java
@@ -29,10 +29,10 @@ public final class PDF417BlackBox1TestCase extends AbstractBlackBoxTestCase {
 
   public PDF417BlackBox1TestCase() {
     super("src/test/resources/blackbox/pdf417-1", new MultiFormatReader(), BarcodeFormat.PDF_417);
-    addTest(10, 10, 0.0f);
-    addTest(10, 10, 90.0f);
-    addTest(10, 10, 180.0f);
-    addTest(10, 10, 270.0f);
+    addTest(11, 11, 0.0f);
+    addTest(11, 11, 90.0f);
+    addTest(11, 11, 180.0f);
+    addTest(11, 11, 270.0f);
   }
 
-}
+}
diff --git a/core/src/test/resources/blackbox/pdf417-1/12.png b/core/src/test/resources/blackbox/pdf417-1/12.png
diff --git a/core/src/test/resources/blackbox/pdf417-1/12.txt b/core/src/test/resources/blackbox/pdf417-1/12.txt
@@ -0,0 +1 @@
++A+CDMEABCDEFGHIJABCDFEFGH