Skip to content

Commit

Permalink
[maven-release-plugin] prepare release zxing-3.4.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@srowen
srowen committed May 18, 2019
1 parent 4132104 commit 67138ce
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions core/pom.xml
View file
Expand Up @@ -18,7 +18,7 @@
<modelVersion>4.0.0</modelVersion>

<artifactId>core</artifactId>
<version>3.4.0-SNAPSHOT</version>
<version>3.4.0</version>
<packaging>jar</packaging>

<dependencies>
Expand All @@ -32,7 +32,7 @@
<parent>
<groupId>com.google.zxing</groupId>
<artifactId>zxing-parent</artifactId>
<version>3.4.0-SNAPSHOT</version>
<version>3.4.0</version>
</parent>

<name>ZXing Core</name>
Expand Down
4 changes: 2 additions & 2 deletions javase/pom.xml
View file
Expand Up @@ -18,7 +18,7 @@
<modelVersion>4.0.0</modelVersion>

<artifactId>javase</artifactId>
<version>3.4.0-SNAPSHOT</version>
<version>3.4.0</version>
<packaging>jar</packaging>

<dependencies>
Expand Down Expand Up @@ -47,7 +47,7 @@
<parent>
<groupId>com.google.zxing</groupId>
<artifactId>zxing-parent</artifactId>
<version>3.4.0-SNAPSHOT</version>
<version>3.4.0</version>
</parent>

<build>
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
View file
Expand Up @@ -19,7 +19,7 @@

<groupId>com.google.zxing</groupId>
<artifactId>zxing-parent</artifactId>
<version>3.4.0-SNAPSHOT</version>
<version>3.4.0</version>
<packaging>pom</packaging>

<dependencyManagement>
Expand Down Expand Up @@ -86,7 +86,7 @@
<proguard.plugin.version>2.0.14</proguard.plugin.version>
<slf4j.version>1.8.0-beta4</slf4j.version>
<!-- This can't reference project.version as some subprojects version differently -->
<zxing.version>3.4.0-SNAPSHOT</zxing.version>
<zxing.version>3.4.0</zxing.version>
<android.platform>22</android.platform>
<maven.scm.version>1.9.5</maven.scm.version>
</properties>
Expand Down Expand Up @@ -686,7 +686,7 @@
<connection>scm:git:https://github.com/zxing/zxing.git</connection>
<developerConnection>scm:git:https://github.com/zxing/zxing.git</developerConnection>
<url>https://github.com/zxing/zxing</url>
<tag>HEAD</tag>
<tag>zxing-3.4.0</tag>
</scm>

<distributionManagement>
Expand Down
4 changes: 2 additions & 2 deletions zxing.appspot.com/pom.xml
View file
Expand Up @@ -18,7 +18,7 @@
<modelVersion>4.0.0</modelVersion>

<artifactId>zxing.appspot.com</artifactId>
<version>3.4.0-SNAPSHOT</version>
<version>3.4.0</version>
<packaging>war</packaging>

<dependencies>
Expand All @@ -33,7 +33,7 @@
<parent>
<groupId>com.google.zxing</groupId>
<artifactId>zxing-parent</artifactId>
<version>3.4.0-SNAPSHOT</version>
<version>3.4.0</version>
</parent>

<properties>
Expand Down
4 changes: 2 additions & 2 deletions zxingorg/pom.xml
View file
Expand Up @@ -18,7 +18,7 @@
<modelVersion>4.0.0</modelVersion>

<artifactId>zxingorg</artifactId>
<version>3.4.0-SNAPSHOT</version>
<version>3.4.0</version>
<packaging>war</packaging>

<dependencies>
Expand Down Expand Up @@ -63,7 +63,7 @@
<parent>
<groupId>com.google.zxing</groupId>
<artifactId>zxing-parent</artifactId>
<version>3.4.0-SNAPSHOT</version>
<version>3.4.0</version>
</parent>

<build>
Expand Down

4 comments on commit 67138ce

@amar-w
Copy link

@amar-w amar-w commented on 67138ce Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @srowen

Requires Java 8+. Note: Android apps using this version must target API 24 or higher.

This means

  • java >= 8
  • targetSdkVersion >= 24 (and not minSdkVersion), right?

I am planning to use com.google.zxing:core:3.4.1 in an android project.

Just thought I will confirm once.

@srowen
Copy link
Contributor Author

@srowen srowen commented on 67138ce Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget, but you may need to require API 24 to use Java 8, rather than just target it

@amar-w
Copy link

@amar-w amar-w commented on 67138ce Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the quick response.

Any way I can verify that? One way would be to try on some devices with SDK < 24. Anything in zxing core code where I can see verify that? Anything in the commit history that might indicate at that - I can go through the history if I get some indicator please- as in what to look for.

(When I built it in a project with minSdk 22 it built however.)

@srowen
Copy link
Contributor Author

@srowen srowen commented on 67138ce Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's java 8 that matters, and it happened years ago. Yes I'd test it to see.

Please sign in to comment.