[5.x] Upgrade Tornado, other Python requirements; support Ubuntu 22.04 #22054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit 1c7954b)
We previously forked tornado.autoreload to work around a problem where it would crash if you introduce a syntax error and not recover if you fix it (tornadoweb/tornado#2398). A much more maintainable workaround for that issue, at least in current Tornado, is to use tornado.autoreload as the main module. Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit bded718)
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit e4bf706)
IOLoop.set_blocking_log_threshold and IOLoop.handle_callback_exception are removed in Tornado 6. Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit 5d69daf)
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit 0ef9309)
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit 52b9c59)
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit c9faefd)
According to the documentation: “Pika does not have any notion of threading in the code. If you want to use Pika with threading, make sure you have a Pika connection per thread, created in that thread. It is not safe to share one Pika connection across threads, with one exception: you may call the connection method add_callback_threadsafe from another thread to schedule a callback within an active pika connection.” https://pika.readthedocs.io/en/stable/faq.html This also means that synchronous Django code running in Tornado will use its own synchronous SimpleQueueClient rather than sharing the asynchronous TornadoQueueClient, which is unfortunate but necessary as they’re about to be on different threads. Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit c263bfd)
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit 6fd1a55)
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit f23bfe9)
Fixes zulip#8913. Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit 7acb642)
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit 25c87cc)
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit e952641)
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit a7cdcbb)
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit f29553d)
Signed-off-by: Anders Kaseorg <anders@zulip.com> (cherry picked from commit e6d8589)
andersk
changed the title
|
Merged, thanks @andersk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to 5.x:
Differences in
prod.txt:(8.x in
maindropped Python 3.7 support)