Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] uploads: Add support for resizing GIF with transparent background. #10679

Closed
wants to merge 1 commit into from

Conversation

HarshitOnGitHub
Copy link
Member

@shubham-padia FYI. This is completely raw as I was doing some testing on the code and haven't cleaned up.

@zulipbot
Copy link
Member

Heads up @HarshitOnGitHub, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

@timabbott
Copy link
Sponsor Member

Closing, since we fixed #10351 another way, and our research suggests that getting Pillow to not have this sort of problem when resizing animated emoji is unlikely to work. It may be worth reporting a bug to upstream Pillow, though, since if future improvements to Pillow make resizing just work, that might let us switch to a better solution. @HarshitOnGitHub would you be up for doing that? There have to be other Python-based projects interested in resizing animated GIFs without breaking transparency, so this seems like something Pillow upstream might have some interest in...

@timabbott timabbott closed this Jan 29, 2019
@HarshitOnGitHub
Copy link
Member Author

@timabbott Sorry for the super-late follow up here, looks like there is already an issue for this: python-pillow/Pillow#3357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants