Skip to content

Commit

Permalink
eslint: Cut "disable" lines for now-disabled no-await-in-loop.
Browse files Browse the repository at this point in the history
We disabled this rule for the whole tree in 4fcfb76; so now
we get to delete these lines that disabled it in specific places
it had popped up.
  • Loading branch information
gnprice committed Apr 11, 2020
1 parent 781af12 commit 4559548
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion src/events/eventActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export const startEventPolling = (queueId: number, eventId: number) => async (

const backoffMachine = new BackoffMachine();

/* eslint-disable no-await-in-loop */

This comment has been minimized.

Copy link
@chrisbobbe

chrisbobbe Apr 11, 2020

Contributor

Mm, thanks for the thoroughness brought by this commit! Apparently I still didn't chase after all of these following #3841 (comment).

// eslint-disable-next-line no-constant-condition
while (true) {
const auth = tryGetAuth(getState());
Expand Down
2 changes: 1 addition & 1 deletion src/outbox/outboxActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export const sendOutbox = () => async (dispatch: Dispatch, getState: GetState) =
dispatch(toggleOutboxSending(true));
const backoffMachine = new BackoffMachine();
while (!trySendMessages(dispatch, getState)) {
await backoffMachine.wait(); // eslint-disable-line no-await-in-loop
await backoffMachine.wait();
}
dispatch(toggleOutboxSending(false));
};
Expand Down
1 change: 0 additions & 1 deletion src/typing/clearTypingNotification.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { getTyping } from '../directSelectors';

export const clearTypingNotification = () => async (dispatch: Dispatch, getState: GetState) => {
// loop to auto dismiss typing notifications after typingNotificationTimeout
/* eslint-disable no-await-in-loop */
// eslint-disable-next-line no-constant-condition
while (true) {
await sleep(15000);
Expand Down

0 comments on commit 4559548

Please sign in to comment.