Add missing held status option

[rudyflores]

Proposed changes

Solves #2452
Add missing status option held for job owner/prefix search

Release Notes

Milestone: 2.11.0

Changelog: Added missing status held option for job searches

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

Further comments

[codecov]

Codecov Report

Patch has no changes to coverable lines.

Files Changed	Coverage
packages/zowe-explorer/src/globals.ts	ø

📢 Thoughts on this report? Let us know!.

[traeok]

LGTM, thanks @rudyflores

[JillieBeanSim]

Hey @rudyflores is there support for zosmf profiles in the Zowe CLI for a status filter of Held? I know Kristina did work on the Zowe CLI side for the other status filters in her PR that also brought in the updated cli dependency with her contributions.

[rudyflores]

Hey @rudyflores is there support for zosmf profiles in the Zowe CLI for a status filter of Held? I know Kristina did work on the Zowe CLI side for the other status filters in her PR that also brought in the updated cli dependency with her contributions.

Make sense, I think the change will have to be made on the Zowe CLI side of things before we go ahead and merge this change in order to have support on z/OSMF profiles for this

[traeok]

Is there support for zosmf profiles in the Zowe CLI for a status filter of Held? I know Kristina did work on the Zowe CLI side for the other status filters in her PR that also brought in the updated cli dependency with her contributions.

@JillieBeanSim @rudyflores By "support for zosmf profiles," does this refer to support within the jobs SDK? As far as I'm aware, we should support the "held" status, as we pass it as a query parameter to GetJobs.getJobsByParameters. Then we filter the response based on job status: https://github.com/zowe/zowe-cli/blob/cc2aaa66006037aa4022d2ca4fa4bc6ea44a49da/packages/zosjobs/src/GetJobs.ts#L211-L221

[rudyflores]

Were you able to view jobs under HELD if you tried to use the filter on your end?

[traeok]

Make sense, I think the change will have to be made on the Zowe CLI side of things before we go ahead and merge this change in order to have support on z/OSMF profiles for this

@rudyflores Turns out that while the logic would work here for filtering by "held" status, this z/OSMF API does not support returning the "held" status. It only returns one of three values: "INPUT", "ACTIVE", "OUTPUT".

Here is the link to the z/OSMF enhancement request:

https://ibm-z-hardware-and-operating-systems.ideas.ibm.com/ideas/ZOS-I-3349

Once this enhancement is implemented, this functionality would work without any changes to Zowe CLI, as the CLI filters the job list based on the status provided to getJobsByParameters.

(thanks @t1m0thyj for mentioning this enhancement request offline)

[t1m0thyj]

I would like for this functionality to be added in Zowe Explorer to filter jobs by Held status 🙂
However I'm afraid we can't support it until z/OSMF is enhanced to return this status as @traeok mentioned 😢

[rudyflores]

Switching this PR to draft until the z/OSMF enhancement is addressed

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication